lib: reduce amount of caught URL errors

PR-URL: #52658 Backport-PR-URL: #56927 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Lemire <[email protected]> Refs: #52697

Author: anonrig

lib/internal/modules/esm/hooks.js

@@ -38,7 +38,7 @@ const{
 ERR_WORKER_UNSERIALIZABLE_ERROR,
 }=require('internal/errors').codes;
 const{exitCodes: { kUnfinishedTopLevelAwait }}=internalBinding('errors');
-const{URL}=require('internal/url');
+const{URLParse}=require('internal/url');
 const{canParse: URLCanParse}=internalBinding('url');
 const{ receiveMessageOnPort }=require('worker_threads');
 const{
@@ -471,11 +471,7 @@ class Hooks{
 
 letresponseURLObj;
 if(typeofresponseURL==='string'){
-try{
-responseURLObj=newURL(responseURL);
-}catch{
-// responseURLObj not defined will throw in next branch.
-}
+responseURLObj=URLParse(responseURL);
 }
 
 if(responseURLObj?.href!==responseURL){

lib/internal/modules/esm/loader.js

@@ -28,14 +28,13 @@ const{
 ERR_UNKNOWN_MODULE_FORMAT,
 }=require('internal/errors').codes;
 const{ getOptionValue }=require('internal/options');
-const{ isURL, pathToFileURL,URL}=require('internal/url');
+const{ isURL, pathToFileURL,URLParse}=require('internal/url');
 const{ emitExperimentalWarning, kEmptyObject }=require('internal/util');
 const{
  compileSourceTextModule,
  getDefaultConditions,
 }=require('internal/modules/esm/utils');
 const{ kImplicitAssertType }=require('internal/modules/esm/assert');
-const{ canParse }=internalBinding('url');
 const{ ModuleWrap, kEvaluating, kEvaluated }=internalBinding('module_wrap');
 const{
  urlToFilename,
@@ -321,8 +320,9 @@ class ModuleLoader{
 getModuleJobForRequire(specifier,parentURL,importAttributes){
 assert(getOptionValue('--experimental-require-module'));
 
-if(canParse(specifier)){
-constprotocol=newURL(specifier).protocol;
+constparsed=URLParse(specifier);
+if(parsed!=null){
+constprotocol=parsed.protocol;
 if(protocol==='https:'||protocol==='http:'){
 thrownewERR_NETWORK_IMPORT_DISALLOWED(specifier,parentURL,
 'ES modules cannot be loaded by require() from the network');

lib/internal/source_map/source_map_cache.js

@@ -39,7 +39,7 @@ const kSourceMappingURLMagicComment = /\/[*/]#\s+sourceMappingURL=(?<sourceMappi
 constkSourceURLMagicComment=/\/[*/]#\s+sourceURL=(?<sourceURL>[^\s]+)/g;
 
 const{ isAbsolute }=require('path');
-const{ fileURLToPath, pathToFileURL,URL}=require('internal/url');
+const{ fileURLToPath, pathToFileURL,URL, URLParse}=require('internal/url');
 
 letSourceMap;
 
@@ -209,21 +209,20 @@ function maybeCacheGeneratedSourceMap(content){
  * @returns{object} deserialized source map JSON object
  */
 functiondataFromUrl(sourceURL,sourceMappingURL){
-try{
-consturl=newURL(sourceMappingURL);
+consturl=URLParse(sourceMappingURL);
+
+if(url!=null){
 switch(url.protocol){
 case'data:':
 returnsourceMapFromDataUrl(sourceURL,url.pathname);
 default:
 debug(`unknown protocol ${url.protocol}`);
 returnnull;
 }
-}catch(err){
-debug(err);
-// If no scheme is present, we assume we are dealing with a file path.
-constmapURL=newURL(sourceMappingURL,sourceURL).href;
-returnsourceMapFromFile(mapURL);
 }
+
+constmapURL=newURL(sourceMappingURL,sourceURL).href;
+returnsourceMapFromFile(mapURL);
 }
 
 // Cache the length of each line in the file that a source map was extracted

lib/internal/url.js

@@ -1624,6 +1624,7 @@ module.exports ={
  installObjectURLMethods,
 URL,
  URLSearchParams,
+URLParse: URL.parse,
  domainToASCII,
  domainToUnicode,
  urlToHttpOptions,