test: fix flaky test-net-socket-timeout

The setTimeout() call is unneeded. If the socket never times out, then the test will never finish. Because timers can be unreliable on machines under load, using setTimeout() here effectively creates a race condition. PR-URL: #10172 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>

Author: Trott

test/parallel/test-net-socket-timeout.js

@@ -1,14 +1,17 @@
 'use strict';
-varcommon=require('../common');
-varnet=require('net');
-varassert=require('assert');
+constcommon=require('../common');
+constnet=require('net');
+constassert=require('assert');
 
 // Verify that invalid delays throw
-varnoop=function(){};
-vars=newnet.Socket();
-varnonNumericDelays=['100',true,false,undefined,null,'',{},noop,[]];
-varbadRangeDelays=[-0.001,-1,-Infinity,Infinity,NaN];
-varvalidDelays=[0,0.001,1,1e6];
+constnoop=function(){};
+consts=newnet.Socket();
+constnonNumericDelays=[
+'100',true,false,undefined,null,'',{},noop,[]
+];
+constbadRangeDelays=[-0.001,-1,-Infinity,Infinity,NaN];
+constvalidDelays=[0,0.001,1,1e6];
+
 
 for(leti=0;i<nonNumericDelays.length;i++){
 assert.throws(function(){
@@ -28,15 +31,11 @@ for (let i = 0; i < validDelays.length; i++){
 });
 }
 
-varserver=net.Server();
+constserver=net.Server();
 server.listen(0,common.mustCall(function(){
-varsocket=net.createConnection(this.address().port);
-socket.setTimeout(100,common.mustCall(function(){
+constsocket=net.createConnection(this.address().port);
+socket.setTimeout(1,common.mustCall(function(){
 socket.destroy();
 server.close();
-clearTimeout(timer);
 }));
-vartimer=setTimeout(function(){
-process.exit(1);
-},common.platformTimeout(200));
 }));