debugger: fix event listener leak in the run command

It should remove both the error and the ready event listeners attached when either of them fires, instead of removing only the one whose corresponding event fires, otherwise the other event listener will always get leaked. PR-URL: #60464 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]>

Author: joyeecheung

lib/internal/debugger/inspect_client.js

@@ -13,7 +13,7 @@ const{
 constBuffer=require('buffer').Buffer;
 constcrypto=require('crypto');
 const{ERR_DEBUGGER_ERROR}=require('internal/errors').codes;
-const{ EventEmitter }=require('events');
+const{ EventEmitter, once}=require('events');
 consthttp=require('http');
 const{URL}=require('internal/url');
 
@@ -343,13 +343,10 @@ class Client extends EventEmitter{
 this.emit('ready');
 };
 
-returnnewPromise((resolve,reject)=>{
-this.once('error',reject);
-this.once('ready',resolve);
-
-httpReq.on('upgrade',handshakeListener);
-httpReq.end();
-});
+constonReady=once(this,'ready');
+httpReq.on('upgrade',handshakeListener);
+httpReq.end();
+returnonReady;
 }
 }
 

test/common/debugger.js

@@ -141,6 +141,10 @@ function startCLI(args, flags = [], spawnOpts ={}, opts ={randomPort: true })
 returngetOutput();
 },
 
+getstderrOutput(){
+returnstderrOutput;
+},
+
 getrawOutput(){
 returnoutputBuffer.join('').toString();
 },

test/parallel/test-debugger-restart-message.js

@@ -31,6 +31,8 @@ const startCLI = require('../common/debugger');
 }finally{
 awaitcli.quit();
 }
+
+assert.doesNotMatch(cli.stderrOutput,/MaxListenersExceededWarning/);
 }
 
 onWaitForInitialBreak();