test: http complete list of non-concat headers

The original test was only testing some of the headers that shouldn't be concatenated as per lib/_http_incoming.js, so now the full list is there. 'content-length` gives a parse error if you set it to a string, so the test for that header uses numbers. PR-URL: #3930 Reviewed-By: Colin Ihrig <[email protected]>

Author: bengl

test/parallel/test-http-response-multiheaders.js

@@ -4,8 +4,21 @@ const common = require('../common');
 consthttp=require('http');
 constassert=require('assert');
 
-// Test that certain response header fields do not repeat
+// Test that certain response header fields do not repeat.
+// 'content-length' should also be in this list, but it needs
+// a numeric value, so it's tested slightly differently.
 constnorepeat=[
+'content-type',
+'user-agent',
+'referer',
+'host',
+'authorization',
+'proxy-authorization',
+'if-modified-since',
+'if-unmodified-since',
+'from',
+'location',
+'max-forwards',
 'retry-after',
 'etag',
 'last-modified',
@@ -17,12 +30,14 @@ const norepeat = [
 constserver=http.createServer(function(req,res){
 varnum=req.headers['x-num'];
 if(num==1){
+res.setHeader('content-length',[1,2]);
 for(constnameofnorepeat){
 res.setHeader(name,['A','B']);
 }
 res.setHeader('X-A',['A','B']);
 }elseif(num==2){
 constheaders={};
+headers['content-length']=[1,2];
 for(constnameofnorepeat){
 headers[name]=['A','B'];
 }
@@ -44,6 +59,7 @@ server.listen(common.PORT, common.mustCall(function(){
 {port:common.PORT,headers:{'x-num': n}},
 common.mustCall(function(res){
 if(n==2)server.close();
+assert.equal(res.headers['content-length'],1);
 for(constnameofnorepeat){
 assert.equal(res.headers[name],'A');
 }