http2: fix flaky test-http2-https-fallback

The test was flaky because it relied on a specific order of asynchronous operation that were fired paralellely. This was true on most platform and conditions, but not all the time. See: #18986 PR-URL: #19093 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Anna Henningsen <[email protected]>

Author: mcollina

test/parallel/test-http2-https-fallback.js

@@ -31,7 +31,7 @@ function onRequest(request, response){
 }));
 }
 
-functiononSession(session){
+functiononSession(session,next){
 constheaders={
 ':path': '/',
 ':method': 'GET',
@@ -54,6 +54,10 @@ function onSession(session){
 
 session.close();
 this.cleanup();
+
+if(typeofnext==='function'){
+next();
+}
 }));
 request.end();
 }
@@ -126,22 +130,31 @@ function onSession(session){
 connect(
 origin,
 clientOptions,
-common.mustCall(onSession.bind({ cleanup, server }))
+common.mustCall(function(session){
+onSession.call({ cleanup, server },
+session,
+common.mustCall(testNoTls));
+})
 );
 
-// HTTP/1.1 client
-get(Object.assign(parse(origin),clientOptions),common.mustNotCall())
-.on('error',common.mustCall(cleanup))
-.end();
-
-// Incompatible ALPN TLS client
-lettext='';
-tls(Object.assign({ port,ALPNProtocols: ['fake']},clientOptions))
-.setEncoding('utf8')
-.on('data',(chunk)=>text+=chunk)
-.on('end',common.mustCall(()=>{
-ok(/UnknownALPNProtocol,expected`h2`tobeavailable/.test(text));
-cleanup();
-}));
+functiontestNoTls(){
+// HTTP/1.1 client
+get(Object.assign(parse(origin),clientOptions),common.mustNotCall)
+.on('error',common.mustCall(cleanup))
+.on('error',common.mustCall(testWrongALPN))
+.end();
+}
+
+functiontestWrongALPN(){
+// Incompatible ALPN TLS client
+lettext='';
+tls(Object.assign({ port,ALPNProtocols: ['fake']},clientOptions))
+.setEncoding('utf8')
+.on('data',(chunk)=>text+=chunk)
+.on('end',common.mustCall(()=>{
+ok(/UnknownALPNProtocol,expected`h2`tobeavailable/.test(text));
+cleanup();
+}));
+}
 }));
 }