tls: fix leak on invalid protocol method

codebytere · aduh95 · commit 55d5e9ec734e · 2025-11-13T22:44:18.000+01:00
PR-URL: #60427 Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/src/crypto/crypto_context.cc b/src/crypto/crypto_context.cc
@@ -1351,7 +1351,6 @@ SecureContext* SecureContext::Create(Environment* env){
 SecureContext::SecureContext(Environment* env, Local<Object> wrap)
 : BaseObject(env, wrap){
 MakeWeak();
- env->external_memory_accounter()->Increase(env->isolate(), kExternalSize);
 }
 
 inline void SecureContext::Reset(){
@@ -1469,6 +1468,8 @@ void SecureContext::Init(const FunctionCallbackInfo<Value>& args){
 if (!sc->ctx_){
 return ThrowCryptoError(env, ERR_get_error(), "SSL_CTX_new");
 }
+
+ env->external_memory_accounter()->Increase(env->isolate(), kExternalSize);
 SSL_CTX_set_app_data(sc->ctx_.get(), sc);
 
 // Disable SSLv2 in the case when method == TLS_method() and the

Original file line number	Diff line number	Diff line change
`@@ -1351,7 +1351,6 @@ SecureContext* SecureContext::Create(Environment* env){`
`1351`	`1351`	`SecureContext::SecureContext(Environment* env, Local<Object> wrap)`
`1352`	`1352`	`: BaseObject(env, wrap){`
`1353`	`1353`	`MakeWeak();`
`1354`		`- env->external_memory_accounter()->Increase(env->isolate(), kExternalSize);`
`1355`	`1354`	`}`
`1356`	`1355`
`1357`	`1356`	`inlinevoidSecureContext::Reset(){`
`@@ -1469,6 +1468,8 @@ void SecureContext::Init(const FunctionCallbackInfo<Value>& args){`
`1469`	`1468`	`if (!sc->ctx_){`
`1470`	`1469`	`returnThrowCryptoError(env, ERR_get_error(), "SSL_CTX_new");`
`1471`	`1470`	`}`
	`1471`	`+`
	`1472`	`+ env->external_memory_accounter()->Increase(env->isolate(), kExternalSize);`
`1472`	`1473`	`SSL_CTX_set_app_data(sc->ctx_.get(), sc);`
`1473`	`1474`
`1474`	`1475`	`// Disable SSLv2 in the case when method == TLS_method() and the`