benchmark,lib,test,tools: use consistent quotes

Trott · MylesBorins · commit 563bed00f5a6 · 2018-03-20T11:33:44.000Z
In preparation for a linting rule, use consistent quotation for properties in objects. PR-URL: #19156 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Roman Reiss <me@silverwind.io>
diff --git a/benchmark/querystring/querystring-stringify.js b/benchmark/querystring/querystring-stringify.js
@@ -17,7 +17,7 @@ function main({type, n }){
 encodemany:{
 '\u0080\u0083\u0089': 'bar',
 '\u008C\u008E\u0099': 'quux',
- xyzzy: '\u00A5q\u00A3r'
+ 'xyzzy': '\u00A5q\u00A3r'
 },
 encodelast:{
 foo: 'bar',
diff --git a/lib/internal/loader/DefaultResolve.js b/lib/internal/loader/DefaultResolve.js
@@ -40,7 +40,7 @@ function search(target, base){
 }
 
 const extensionFormatMap ={
- __proto__: null,
+ '__proto__': null,
 '.mjs': 'esm',
 '.json': 'json',
 '.node': 'addon',
diff --git a/test/doctool/test-doctool-json.js b/test/doctool/test-doctool-json.js
@@ -102,9 +102,9 @@ const testData = [
 meta:{
 added: ['v5.3.0', 'v4.2.0'],
 changes: [
-{version: 'v4.2.0',
+{'version': 'v4.2.0',
 'pr-url': 'https://github.com/nodejs/node/pull/3276',
- description: 'The `error` parameter can now be ' +
+ 'description': 'The `error` parameter can now be ' +
 'an arrow function.'
 }
 ]
diff --git a/test/parallel/test-http-client-headers-array.js b/test/parallel/test-http-client-headers-array.js
@@ -9,8 +9,8 @@ function execute(options){
 http.createServer(function(req, res){
 const expectHeaders ={
 'x-foo': 'boom',
- cookie: 'a=1; b=2; c=3',
- connection: 'close'
+ 'cookie': 'a=1; b=2; c=3',
+ 'connection': 'close'
 };
 
 // no Host header when you set headers an array
diff --git a/test/parallel/test-http-raw-headers.js b/test/parallel/test-http-raw-headers.js
@@ -37,10 +37,10 @@ http.createServer(function(req, res){
 'close'
 ];
 const expectHeaders ={
- host: `localhost:${this.address().port}`,
+ 'host': `localhost:${this.address().port}`,
 'transfer-encoding': 'CHUNKED',
 'x-bar': 'yoyoyo',
- connection: 'close'
+ 'connection': 'close'
 };
 const expectRawTrailers = [
 'x-bAr',
@@ -96,9 +96,9 @@ http.createServer(function(req, res){
 'chunked'
 ];
 const expectHeaders ={
- trailer: 'x-foo',
- date: null,
- connection: 'close',
+ 'trailer': 'x-foo',
+ 'date': null,
+ 'connection': 'close',
 'transfer-encoding': 'chunked'
 };
 res.rawHeaders[3] = null;
diff --git a/test/parallel/test-http2-compat-expect-continue-check.js b/test/parallel/test-http2-compat-expect-continue-check.js
@@ -33,7 +33,7 @@ server.listen(0, common.mustCall(() =>{
 const client = http2.connect(`http://localhost:${server.address().port}`);
 const req = client.request({
 ':method': 'POST',
- expect: '100-continue'
+ 'expect': '100-continue'
 });
 
 let gotContinue = false;
diff --git a/test/parallel/test-http2-compat-expect-continue.js b/test/parallel/test-http2-compat-expect-continue.js
@@ -29,7 +29,7 @@ server.on('listening', common.mustCall(() =>{
 const client = http2.connect(`http://localhost:${server.address().port}`);
 const req = client.request({
 ':method': 'POST',
- expect: '100-continue'
+ 'expect': '100-continue'
 });
 
 let gotContinue = false;
diff --git a/test/parallel/test-http2-compat-expect-handling.js b/test/parallel/test-http2-compat-expect-handling.js
@@ -30,7 +30,7 @@ function nextTest(testsToRun){
 ':method': 'GET',
 ':scheme': 'http',
 ':authority': `localhost:${port}`,
- expect: expectValue
+ 'expect': expectValue
 });
 
 req.on('response', common.mustCall((headers) =>{
diff --git a/test/parallel/test-http2-cookies.js b/test/parallel/test-http2-cookies.js
@@ -41,8 +41,8 @@ server.on('listening', common.mustCall(() =>{
 
 const req = client.request({
 ':path': '/',
- abc: [1, 2, 3],
- cookie: ['a=b', 'c=d', 'e=f'],
+ 'abc': [1, 2, 3],
+ 'cookie': ['a=b', 'c=d', 'e=f'],
 });
 req.resume();
 
diff --git a/test/parallel/test-http2-server-rst-before-respond.js b/test/parallel/test-http2-server-rst-before-respond.js
@@ -17,7 +17,7 @@ function onStream(stream, headers, flags){
 common.expectsError(() =>{
 stream.additionalHeaders({
 ':status': 123,
- abc: 123
+ 'abc': 123
 });
 },{code: 'ERR_HTTP2_INVALID_STREAM' });
 }
diff --git a/test/parallel/test-http2-server-rst-stream.js b/test/parallel/test-http2-server-rst-stream.js
@@ -40,7 +40,7 @@ server.listen(0, common.mustCall(() =>{
 tests.forEach((test) =>{
 const req = client.request({
 ':method': 'POST',
- rstcode: test[0]
+ 'rstcode': test[0]
 });
 req.on('close', common.mustCall((code) =>{
 assert.strictEqual(code, test[0]);
diff --git a/test/parallel/test-querystring.js b/test/parallel/test-querystring.js
@@ -75,8 +75,8 @@ const qsTestCases = [
 ['foo&bar=baz', 'foo=&bar=baz',{foo: '', bar: 'baz' }],
 ['a=b&c&d=e', 'a=b&c=&d=e',{a: 'b', c: '', d: 'e' }],
 ['a=b&c=&d=e', 'a=b&c=&d=e',{a: 'b', c: '', d: 'e' }],
- ['a=b&=c&d=e', 'a=b&=c&d=e',{a: 'b', '': 'c', d: 'e' }],
- ['a=b&=&c=d', 'a=b&=&c=d',{a: 'b', '': '', c: 'd' }],
+ ['a=b&=c&d=e', 'a=b&=c&d=e',{'a': 'b', '': 'c', 'd': 'e' }],
+ ['a=b&=&c=d', 'a=b&=&c=d',{'a': 'b', '': '', 'c': 'd' }],
 ['&&foo=bar&&', 'foo=bar',{foo: 'bar' }],
 ['&', '',{}],
 ['&&&&', '',{}],
diff --git a/test/parallel/test-vm-module-link.js b/test/parallel/test-vm-module-link.js
@@ -88,7 +88,7 @@ async function circular(){
 
 async function circular2(){
 const sourceMap ={
- root: `
+ 'root': `
 import * as a from './a.mjs';
 import * as b from './b.mjs';
 if (!('fromA' in a))
diff --git a/tools/eslint-rules/no-unescaped-regexp-dot.js b/tools/eslint-rules/no-unescaped-regexp-dot.js
@@ -120,10 +120,10 @@ module.exports = function(context){
 }
 
 return{
- TemplateLiteral: checkLiteral,
- Literal: checkLiteral,
- CallExpression: checkRegExpStart,
- NewExpression: checkRegExpStart,
+ 'TemplateLiteral': checkLiteral,
+ 'Literal': checkLiteral,
+ 'CallExpression': checkRegExpStart,
+ 'NewExpression': checkRegExpStart,
 'CallExpression:exit': checkRegExpEnd,
 'NewExpression:exit': checkRegExpEnd
 };

Original file line number	Diff line number	Diff line change
`@@ -40,7 +40,7 @@ function search(target, base){`
`40`	`40`	`}`
`41`	`41`
`42`	`42`	`constextensionFormatMap={`
`43`		`-__proto__: null,`
	`43`	`+'__proto__': null,`
`44`	`44`	`'.mjs': 'esm',`
`45`	`45`	`'.json': 'json',`
`46`	`46`	`'.node': 'addon',`
Original file line number	Diff line number	Diff line change
`@@ -102,9 +102,9 @@ const testData = [`
`102`	`102`	`meta: {`
`103`	`103`	`added: ['v5.3.0','v4.2.0'],`
`104`	`104`	`changes: [`
`105`		`-{version: 'v4.2.0',`
	`105`	`+{'version': 'v4.2.0',`
`106`	`106`	`'pr-url': 'https://github.com/nodejs/node/pull/3276',`
`107`		-description: 'The `error` parameter can now be '+
	`107`	+'description': 'The `error` parameter can now be '+
`108`	`108`	`'an arrow function.'`
`109`	`109`	`}`
`110`	`110`	`]`
-Original file line number
+Diff line change
 constclient=http2.connect(`http://localhost:${server.address().port}`);
 constreq=client.request({
 ':method': 'POST',
 -expect: '100-continue'
 +'expect': '100-continue'
 });
 letgotContinue=false;
Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,7 @@ function onStream(stream, headers, flags){`
`17`	`17`	`common.expectsError(()=>{`
`18`	`18`	`stream.additionalHeaders({`
`19`	`19`	`':status': 123,`
`20`		`-abc: 123`
	`20`	`+'abc': 123`
`21`	`21`	`});`
`22`	`22`	`},{code: 'ERR_HTTP2_INVALID_STREAM'});`
`23`	`23`	`}`