sqlite: add DatabaseSync.prototype.isOpen

This commit adds a getter to indicate whether or not the database is currently open. Fixes: #57521 PR-URL: #57522 Reviewed-By: Ulises Gascón <[email protected]> Reviewed-By: Edy Silva <[email protected]> Reviewed-By: Chemi Atlow <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>

Author: cjihrig

doc/api/sqlite.md

@@ -192,6 +192,14 @@ added: v23.5.0
 This method is used to create SQLite user-defined functions. This method is a
 wrapper around [`sqlite3_create_function_v2()`][].
 
+### `database.isOpen`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+*{boolean} Whether the database is currently open or not.
+
 ### `database.open()`
 
 <!-- YAML

src/node_sqlite.cc

@@ -767,6 +767,12 @@ void DatabaseSync::Open(const FunctionCallbackInfo<Value>& args){
  db->Open();
 }
 
+voidDatabaseSync::IsOpenGetter(const FunctionCallbackInfo<Value>& args){
+ DatabaseSync* db;
+ASSIGN_OR_RETURN_UNWRAP(&db, args.This());
+ args.GetReturnValue().Set(db->IsOpen());
+}
+
 voidDatabaseSync::Close(const FunctionCallbackInfo<Value>& args){
  DatabaseSync* db;
 ASSIGN_OR_RETURN_UNWRAP(&db, args.This());
@@ -2247,6 +2253,10 @@ static void Initialize(Local<Object> target,
  DatabaseSync::EnableLoadExtension);
 SetProtoMethod(
  isolate, db_tmpl, "loadExtension", DatabaseSync::LoadExtension);
+SetSideEffectFreeGetter(isolate,
+ db_tmpl,
+FIXED_ONE_BYTE_STRING(isolate, "isOpen"),
+ DatabaseSync::IsOpenGetter);
 SetConstructorFunction(context, target, "DatabaseSync", db_tmpl);
 SetConstructorFunction(context,
  target,

src/node_sqlite.h

@@ -55,6 +55,7 @@ class DatabaseSync : public BaseObject{
 voidMemoryInfo(MemoryTracker* tracker) constoverride;
 staticvoidNew(const v8::FunctionCallbackInfo<v8::Value>& args);
 staticvoidOpen(const v8::FunctionCallbackInfo<v8::Value>& args);
+staticvoidIsOpenGetter(const v8::FunctionCallbackInfo<v8::Value>& args);
 staticvoidClose(const v8::FunctionCallbackInfo<v8::Value>& args);
 staticvoidPrepare(const v8::FunctionCallbackInfo<v8::Value>& args);
 staticvoidExec(const v8::FunctionCallbackInfo<v8::Value>& args);

test/parallel/test-sqlite-database-sync.js

@@ -172,41 +172,50 @@ suite('DatabaseSync.prototype.open()', () =>{
 constdb=newDatabaseSync(dbPath,{open: false});
 t.after(()=>{db.close();});
 
+t.assert.strictEqual(db.isOpen,false);
 t.assert.strictEqual(existsSync(dbPath),false);
 t.assert.strictEqual(db.open(),undefined);
+t.assert.strictEqual(db.isOpen,true);
 t.assert.strictEqual(existsSync(dbPath),true);
 });
 
 test('throws if database is already open',(t)=>{
 constdb=newDatabaseSync(nextDb(),{open: false});
 t.after(()=>{db.close();});
 
+t.assert.strictEqual(db.isOpen,false);
 db.open();
+t.assert.strictEqual(db.isOpen,true);
 t.assert.throws(()=>{
 db.open();
 },{
 code: 'ERR_INVALID_STATE',
 message: /databaseisalreadyopen/,
 });
+t.assert.strictEqual(db.isOpen,true);
 });
 });
 
 suite('DatabaseSync.prototype.close()',()=>{
 test('closes an open database connection',(t)=>{
 constdb=newDatabaseSync(nextDb());
 
+t.assert.strictEqual(db.isOpen,true);
 t.assert.strictEqual(db.close(),undefined);
+t.assert.strictEqual(db.isOpen,false);
 });
 
 test('throws if database is not open',(t)=>{
 constdb=newDatabaseSync(nextDb(),{open: false});
 
+t.assert.strictEqual(db.isOpen,false);
 t.assert.throws(()=>{
 db.close();
 },{
 code: 'ERR_INVALID_STATE',
 message: /databaseisnotopen/,
 });
+t.assert.strictEqual(db.isOpen,false);
 });
 });