src: avoid strcmp in SecureContext::Init

PR-URL: #34329 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: tniessen

src/node_crypto.cc

@@ -551,73 +551,65 @@ void SecureContext::Init(const FunctionCallbackInfo<Value>& args){
 // are still accepted. They are OpenSSL's way of saying that all known
 // protocols below TLS 1.3 are supported unless explicitly disabled (which
 // we do below for SSLv2 and SSLv3.)
-if (strcmp(*sslmethod, "SSLv2_method") == 0){
+if (sslmethod == "SSLv2_method" ||
+ sslmethod == "SSLv2_server_method" ||
+ sslmethod == "SSLv2_client_method"){
 THROW_ERR_TLS_INVALID_PROTOCOL_METHOD(env, "SSLv2 methods disabled");
 return;
- } elseif (strcmp(*sslmethod, "SSLv2_server_method") == 0){
-THROW_ERR_TLS_INVALID_PROTOCOL_METHOD(env, "SSLv2 methods disabled");
-return;
- } elseif (strcmp(*sslmethod, "SSLv2_client_method") == 0){
-THROW_ERR_TLS_INVALID_PROTOCOL_METHOD(env, "SSLv2 methods disabled");
-return;
- } elseif (strcmp(*sslmethod, "SSLv3_method") == 0){
-THROW_ERR_TLS_INVALID_PROTOCOL_METHOD(env, "SSLv3 methods disabled");
-return;
- } elseif (strcmp(*sslmethod, "SSLv3_server_method") == 0){
-THROW_ERR_TLS_INVALID_PROTOCOL_METHOD(env, "SSLv3 methods disabled");
-return;
- } elseif (strcmp(*sslmethod, "SSLv3_client_method") == 0){
+ } elseif (sslmethod == "SSLv3_method" ||
+ sslmethod == "SSLv3_server_method" ||
+ sslmethod == "SSLv3_client_method"){
 THROW_ERR_TLS_INVALID_PROTOCOL_METHOD(env, "SSLv3 methods disabled");
 return;
- } elseif (strcmp(*sslmethod, "SSLv23_method") == 0){
+ } elseif (sslmethod== "SSLv23_method"){
  max_version = TLS1_2_VERSION;
- } elseif (strcmp(*sslmethod, "SSLv23_server_method") == 0){
+ } elseif (sslmethod== "SSLv23_server_method"){
  max_version = TLS1_2_VERSION;
  method = TLS_server_method();
- } elseif (strcmp(*sslmethod, "SSLv23_client_method") == 0){
+ } elseif (sslmethod== "SSLv23_client_method"){
  max_version = TLS1_2_VERSION;
  method = TLS_client_method();
- } elseif (strcmp(*sslmethod, "TLS_method") == 0){
+ } elseif (sslmethod== "TLS_method"){
  min_version = 0;
  max_version = MAX_SUPPORTED_VERSION;
- } elseif (strcmp(*sslmethod, "TLS_server_method") == 0){
+ } elseif (sslmethod== "TLS_server_method"){
  min_version = 0;
  max_version = MAX_SUPPORTED_VERSION;
  method = TLS_server_method();
- } elseif (strcmp(*sslmethod, "TLS_client_method") == 0){
+ } elseif (sslmethod== "TLS_client_method"){
  min_version = 0;
  max_version = MAX_SUPPORTED_VERSION;
  method = TLS_client_method();
- } elseif (strcmp(*sslmethod, "TLSv1_method") == 0){
+ } elseif (sslmethod== "TLSv1_method"){
  min_version = TLS1_VERSION;
  max_version = TLS1_VERSION;
- } elseif (strcmp(*sslmethod, "TLSv1_server_method") == 0){
+ } elseif (sslmethod== "TLSv1_server_method"){
  min_version = TLS1_VERSION;
  max_version = TLS1_VERSION;
  method = TLS_server_method();
- } elseif (strcmp(*sslmethod, "TLSv1_client_method") == 0){
+ } elseif (sslmethod== "TLSv1_client_method"){
  min_version = TLS1_VERSION;
  max_version = TLS1_VERSION;
  method = TLS_client_method();
- } elseif (strcmp(*sslmethod, "TLSv1_1_method") == 0){
+ } elseif (sslmethod== "TLSv1_1_method"){
  min_version = TLS1_1_VERSION;
  max_version = TLS1_1_VERSION;
- } elseif (strcmp(*sslmethod, "TLSv1_1_server_method") == 0){
+ } elseif (sslmethod== "TLSv1_1_server_method"){
  min_version = TLS1_1_VERSION;
  max_version = TLS1_1_VERSION;
  method = TLS_server_method();
- } elseif (strcmp(*sslmethod, "TLSv1_1_client_method") == 0){
+ } elseif (sslmethod== "TLSv1_1_client_method"){
  min_version = TLS1_1_VERSION;
  max_version = TLS1_1_VERSION;
  method = TLS_client_method();
- } elseif (strcmp(*sslmethod, "TLSv1_2_method") == 0){
+ } elseif (sslmethod== "TLSv1_2_method"){
  min_version = TLS1_2_VERSION;
  max_version = TLS1_2_VERSION;
- } elseif (strcmp(*sslmethod, "TLSv1_2_server_method") == 0){
+ } elseif (sslmethod== "TLSv1_2_server_method"){
  min_version = TLS1_2_VERSION;
  max_version = TLS1_2_VERSION;
  method = TLS_server_method();
- } elseif (strcmp(*sslmethod, "TLSv1_2_client_method") == 0){
+ } elseif (sslmethod== "TLSv1_2_client_method"){
  min_version = TLS1_2_VERSION;
  max_version = TLS1_2_VERSION;
  method = TLS_client_method();

src/util.h

@@ -481,6 +481,10 @@ class Utf8Value : public MaybeStackBuffer<char>{
 explicitUtf8Value(v8::Isolate* isolate, v8::Local<v8::Value> value);
 
 inline std::string ToString() const{returnstd::string(out(), length())}
+
+inlinebooloperator==(constchar* a) const{
+returnstrcmp(out(), a) == 0;
+ }
 };
 
 classTwoByteValue : publicMaybeStackBuffer<uint16_t>{