src: no SetImmediate from destructor in stream_pipe code

Guard against running `SetImmediate()` from the destructor. The object will not be alive or usable in the callback, so it does not make sense to attempt to schedule the `SetImmediate()`. Backport-PR-URL: #32301 PR-URL: #30666Fixes: #30643 Refs: #30374 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: addaleax

src/stream_pipe.cc

@@ -42,7 +42,7 @@ StreamPipe::StreamPipe(StreamBase* source,
 }
 
 StreamPipe::~StreamPipe(){
-Unpipe();
+Unpipe(true);
 }
 
 StreamBase* StreamPipe::source(){
@@ -53,7 +53,7 @@ StreamBase* StreamPipe::sink(){
 returnstatic_cast<StreamBase*>(writable_listener_.stream());
 }
 
-voidStreamPipe::Unpipe(){
+voidStreamPipe::Unpipe(bool is_in_deletion){
 if (is_closed_)
 return;
 
@@ -69,6 +69,8 @@ void StreamPipe::Unpipe(){
 if (pending_writes_ == 0)
 sink()->RemoveStreamListener(&writable_listener_);
 
+if (is_in_deletion) return;
+
 // Delay the JS-facing part with SetImmediate, because this might be from
 // inside the garbage collector, so we can’t run JS here.
  HandleScope handle_scope(env()->isolate());

src/stream_pipe.h

@@ -12,7 +12,7 @@ class StreamPipe : public AsyncWrap{
 StreamPipe(StreamBase* source, StreamBase* sink, v8::Local<v8::Object> obj);
 ~StreamPipe() override;
 
-voidUnpipe();
+voidUnpipe(bool is_in_deletion = false);
 
 staticvoidNew(const v8::FunctionCallbackInfo<v8::Value>& args);
 staticvoidStart(const v8::FunctionCallbackInfo<v8::Value>& args);