src: add nullptr check for session in DEBUG macro

Currenlty when configuring --debug-http2 /test/parallel/test-http2-getpackedsettings.js will segment fault: $ out/Debug/node test/parallel/test-http2-getpackedsettings.js Segmentation fault: 11 This is happening because the settings is created with the Environment in PackSettings: Http2Session::Http2Settings settings(env); This will cause the session to be set to nullptr. When the init function is later called the expanded DEBUG_HTTP2SESSION macro will cause the segment fault when the session is dereferenced. Backport-PR-URL: #20456 PR-URL: #18815 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: danbev

src/node_http2.h

@@ -39,16 +39,20 @@ void inline debug_vfprintf(const char* format, ...){
 #defineDEBUG_HTTP2(...) debug_vfprintf(__VA_ARGS__);
 #defineDEBUG_HTTP2SESSION(session, message) \
 do{\
-DEBUG_HTTP2("Http2Session %s (%.0lf) " message "\n", \
- session->TypeName(), \
- session->get_async_id()); \
+if (session != nullptr){\
+DEBUG_HTTP2("Http2Session %s (%.0lf) " message "\n", \
+ session->TypeName(), \
+ session->get_async_id()); \
+ } \
  } while (0)
 #defineDEBUG_HTTP2SESSION2(session, message, ...) \
 do{\
-DEBUG_HTTP2("Http2Session %s (%.0lf) " message "\n", \
- session->TypeName(), \
- session->get_async_id(), \
+if (session != nullptr){\
+DEBUG_HTTP2("Http2Session %s (%.0lf) " message "\n", \
+ session->TypeName(), \
+ session->get_async_id(), \
  __VA_ARGS__); \
+ } \
  } while (0)
 #defineDEBUG_HTTP2STREAM(stream, message) \
 do{\