Skip to content

Commit 5e138fe

Browse files
jasnellevanlucas
authored andcommitted
test: skip whatwg url parse and setter tests when icu is missing
the WHATWG url parser relies on ICU's punycode implementation. A handful of the standard tests fail when ICU is not present because of the additional checks that are not implemented. For now, skip the parse and setter tests if ICU is not present. PR-URL: #9246 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Johan Bergström <[email protected]> Reviewed-By: Ben Noordhuis <[email protected]>
1 parent a39b98e commit 5e138fe

File tree

2 files changed

+14
-0
lines changed

2 files changed

+14
-0
lines changed

‎test/parallel/test-whatwg-url-parsing.js‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
'use strict';
22

33
constcommon=require('../common');
4+
5+
if(!common.hasIntl){
6+
// A handful of the tests fail when ICU is not included.
7+
common.skip('missing Intl... skipping test');
8+
return;
9+
}
10+
411
constURL=require('url').URL;
512
constpath=require('path');
613
constassert=require('assert');

‎test/parallel/test-whatwg-url-setters.js‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,13 @@
11
'use strict';
22

33
constcommon=require('../common');
4+
5+
if(!common.hasIntl){
6+
// A handful of the tests fail when ICU is not included.
7+
common.skip('missing Intl... skipping test');
8+
return;
9+
}
10+
411
constpath=require('path');
512
constURL=require('url').URL;
613
constassert=require('assert');

0 commit comments

Comments
(0)