test: fail when child dies in fork-net

joyeecheung · Italo A. Casas · commit 5f6025ba68c0 · 2017-03-20T10:19:16.000-04:00
Previously when the child dies with errors in this test, the parent will just hang and timeout, the errors in the child would be swallowed. This makes it fail so at least there is more information about why this test fails. Also removes the unnecessary child.kill() call. PR-URL: #11684 Ref: #11667 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/test/parallel/test-child-process-fork-net.js b/test/parallel/test-child-process-fork-net.js
@@ -1,5 +1,5 @@
 'use strict';
-require('../common');
+const common = require('../common');
 const assert = require('assert');
 const fork = require('child_process').fork;
 const net = require('net');
@@ -60,9 +60,10 @@ if (process.argv[2] === 'child'){
 
 const child = fork(process.argv[1], ['child']);
 
- child.on('exit', function(){
- console.log('CHILD: died');
- });
+ child.on('exit', common.mustCall(function(code, signal){
+ const message = `CHILD: died with ${code}, ${signal}`;
+ assert.strictEqual(code, 0, message);
+ }));
 
 // send net.Server to child and test by connecting
 const testServer = function(callback){
@@ -171,7 +172,6 @@ if (process.argv[2] === 'child'){
 
 testSocket(function(){
 socketSuccess = true;
- child.kill();
 });
 });
 

-Original file line number
+Diff line change
@@ @@ -1,5 +1,5 @@ @@
 'use strict';
 -require('../common');
 +constcommon=require('../common');
 constassert=require('assert');
 constfork=require('child_process').fork;
 constnet=require('net');
 constchild=fork(process.argv[1],['child']);
 -child.on('exit',function(){
 -console.log('CHILD: died');
 -});
 +child.on('exit',common.mustCall(function(code,signal){
 +constmessage=`CHILD: died with ${code}, ${signal}`;
 +assert.strictEqual(code,0,message);
 +}));
 // send net.Server to child and test by connecting
 consttestServer=function(callback){
 testSocket(function(){
 socketSuccess=true;
 -child.kill();
 });
 });