src: remove HandleWrap instances from list once closed

This allows keeping `BaseObjectPtr`s to `HandleWrap` instances. Previously, the pointer kept the `HandleWrap` object alive, leaving the Environment cleanup code that waits for the handle list to drain in a busy loop, because only the `HandleWrap` destructor removed the item from the list. Refs: nodejs/quic#165 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Backport-PR-URL: #32301 PR-URL: #30374 Refs: nodejs/quic#141 Refs: nodejs/quic#149 Refs: nodejs/quic#141 Reviewed-By: David Carlier <[email protected]>

Author: addaleax

src/handle_wrap.cc

@@ -127,6 +127,7 @@ void HandleWrap::OnClose(uv_handle_t* handle){
  wrap->state_ = kClosed;
 
  wrap->OnClose();
+ wrap->handle_wrap_queue_.Remove();
 
 if (!wrap->persistent().IsEmpty() &&
  wrap->object()->Has(env->context(), env->handle_onclose_symbol())