repl: refactor lib/repl.js

* remove unnecessary backslash (`\`) escaping in regular expressions * favor `===` over `==` * multiline arrays indentation consistent with other indentation PR-URL: #9374 Reviewed-By: Rod Vagg <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Roman Reiss <[email protected]>

Author: Trott

lib/repl.js

@@ -40,12 +40,12 @@ const parentModule = module;
 constreplMap=newWeakMap();
 
 constGLOBAL_OBJECT_PROPERTIES=['NaN','Infinity','undefined',
-'eval','parseInt','parseFloat','isNaN','isFinite','decodeURI',
-'decodeURIComponent','encodeURI','encodeURIComponent',
-'Object','Function','Array','String','Boolean','Number',
-'Date','RegExp','Error','EvalError','RangeError',
-'ReferenceError','SyntaxError','TypeError','URIError',
-'Math','JSON'];
+'eval','parseInt','parseFloat','isNaN','isFinite','decodeURI',
+'decodeURIComponent','encodeURI','encodeURIComponent',
+'Object','Function','Array','String','Boolean','Number',
+'Date','RegExp','Error','EvalError','RangeError',
+'ReferenceError','SyntaxError','TypeError','URIError',
+'Math','JSON'];
 constGLOBAL_OBJECT_PROPERTY_MAP={};
 GLOBAL_OBJECT_PROPERTIES.forEach((p)=>GLOBAL_OBJECT_PROPERTY_MAP[p]=p);
 
@@ -783,7 +783,7 @@ ArrayStream.prototype.writable = true;
 ArrayStream.prototype.resume=function(){};
 ArrayStream.prototype.write=function(){};
 
-constrequireRE=/\brequire\s*\(['"](([\w\.\/-]+\/)?([\w\.\/-]*))/;
+constrequireRE=/\brequire\s*\(['"](([\w./-]+\/)?([\w./-]*))/;
 constsimpleExpressionRE=
 /(([a-zA-Z_$](?:\w|\$)*)\.)*([a-zA-Z_$](?:\w|\$)*)\.?$/;
 
@@ -1036,7 +1036,7 @@ function complete(line, callback){
 varnewCompletionGroups=[];
 for(i=0;i<completionGroups.length;i++){
 group=completionGroups[i].filter(function(elem){
-returnelem.indexOf(filter)==0;
+returnelem.indexOf(filter)===0;
 });
 if(group.length){
 newCompletionGroups.push(group);
@@ -1341,8 +1341,8 @@ function regexpEscape(s){
 // TODO(princejwesley): Remove it prior to v8.0.0 release
 // Reference: https://github.com/nodejs/node/pull/7829
 REPLServer.prototype.convertToContext=util.deprecate(function(cmd){
-constscopeVar=/^\s*var\s*([_\w\$]+)(.*)$/m;
-constscopeFunc=/^\s*function\s*([_\w\$]+)/;
+constscopeVar=/^\s*var\s*([\w$]+)(.*)$/m;
+constscopeFunc=/^\s*function\s*([\w$]+)/;
 varmatches;
 
 // Replaces: var foo = "bar" with: self.context.foo = bar;