crypto: remove unused SSLWrap handle methods

One was not used at all, and the other was only used in a test, which I converted to use the more standard `ShutdownWrap` API. PR-URL: #22216 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Author: maclover7

src/node_crypto.cc

@@ -1381,13 +1381,11 @@ void SSLWrap<Base>::AddMethods(Environment* env, Local<FunctionTemplate> t){
  env->SetProtoMethod(t, "setSession", SetSession);
  env->SetProtoMethod(t, "loadSession", LoadSession);
  env->SetProtoMethodNoSideEffect(t, "isSessionReused", IsSessionReused);
- env->SetProtoMethodNoSideEffect(t, "isInitFinished", IsInitFinished);
  env->SetProtoMethodNoSideEffect(t, "verifyError", VerifyError);
  env->SetProtoMethodNoSideEffect(t, "getCurrentCipher", GetCurrentCipher);
  env->SetProtoMethod(t, "endParser", EndParser);
  env->SetProtoMethod(t, "certCbDone", CertCbDone);
  env->SetProtoMethod(t, "renegotiate", Renegotiate);
- env->SetProtoMethod(t, "shutdownSSL", Shutdown);
  env->SetProtoMethodNoSideEffect(t, "getTLSTicket", GetTLSTicket);
  env->SetProtoMethod(t, "newSessionDone", NewSessionDone);
  env->SetProtoMethod(t, "setOCSPResponse", SetOCSPResponse);
@@ -1993,16 +1991,6 @@ void SSLWrap<Base>::Renegotiate(const FunctionCallbackInfo<Value>& args){
 }
 
 
-template <classBase>
-void SSLWrap<Base>::Shutdown(const FunctionCallbackInfo<Value>& args){
- Base* w;
-ASSIGN_OR_RETURN_UNWRAP(&w, args.Holder());
-
-int rv = SSL_shutdown(w->ssl_.get());
- args.GetReturnValue().Set(rv);
-}
-
-
 template <classBase>
 void SSLWrap<Base>::GetTLSTicket(const FunctionCallbackInfo<Value>& args){
  Base* w;
@@ -2136,15 +2124,6 @@ void SSLWrap<Base>::SetMaxSendFragment(
 #endif// SSL_set_max_send_fragment
 
 
-template <classBase>
-void SSLWrap<Base>::IsInitFinished(const FunctionCallbackInfo<Value>& args){
- Base* w;
-ASSIGN_OR_RETURN_UNWRAP(&w, args.Holder());
-bool yes = SSL_is_init_finished(w->ssl_.get());
- args.GetReturnValue().Set(yes);
-}
-
-
 template <classBase>
 void SSLWrap<Base>::VerifyError(const FunctionCallbackInfo<Value>& args){
  Base* w;

test/parallel/test-tls-close-notify.js

@@ -27,14 +27,17 @@ if (!common.hasCrypto)
 
 consttls=require('tls');
 constfixtures=require('../common/fixtures');
+const{ ShutdownWrap }=process.binding('stream_wrap');
 
 constserver=tls.createServer({
 key: fixtures.readKey('agent1-key.pem'),
 cert: fixtures.readKey('agent1-cert.pem')
 },function(c){
 // Send close-notify without shutting down TCP socket
-if(c._handle.shutdownSSL()!==1)
-c._handle.shutdownSSL();
+constreq=newShutdownWrap();
+req.oncomplete=common.mustCall(()=>{});
+req.handle=c._handle;
+c._handle.shutdown(req);
 }).listen(0,common.mustCall(function(){
 constc=tls.connect(this.address().port,{
 rejectUnauthorized: false