loader: remove unused error code in module_job

PR-URL: #21354 Reviewed-By: Bradley Farias <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Guy Bedford <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Author: devsnek

lib/internal/modules/esm/module_job.js

@@ -14,8 +14,6 @@ class ModuleJob{
 // `moduleProvider` is a function
 constructor(loader,url,moduleProvider,isMain){
 this.loader=loader;
-this.error=null;
-this.hadError=false;
 this.isMain=isMain;
 
 // This is a Promise<{module, reflect }>, whose fields will be copied
@@ -72,15 +70,7 @@ class ModuleJob{
 constdependencyJobs=awaitmoduleJob.linked;
 returnPromise.all(dependencyJobs.map(addJobsToDependencyGraph));
 };
-try{
-awaitaddJobsToDependencyGraph(this);
-}catch(e){
-if(!this.hadError){
-this.error=e;
-this.hadError=true;
-}
-throwe;
-}
+awaitaddJobsToDependencyGraph(this);
 try{
 if(this.isMain&&process._breakFirstLine){
 deleteprocess._breakFirstLine;
@@ -103,13 +93,7 @@ class ModuleJob{
 
 asyncrun(){
 constmodule=awaitthis.instantiate();
-try{
-module.evaluate(-1,false);
-}catch(e){
-this.hadError=true;
-this.error=e;
-throwe;
-}
+module.evaluate(-1,false);
 returnmodule;
 }
 }

test/es-module/test-esm-error-cache.js

@@ -0,0 +1,28 @@
+'use strict';
+
+// Flags: --experimental-modules
+
+constcommon=require('../common');
+constassert=require('assert');
+
+common.crashOnUnhandledRejection();
+
+constfile='../../fixtures/syntax/bad_syntax.js';
+
+leterror;
+(async()=>{
+try{
+awaitimport(file);
+}catch(e){
+assert.strictEqual(e.name,'SyntaxError');
+error=e;
+}
+
+assert(error);
+
+try{
+awaitimport(file);
+}catch(e){
+assert.strictEqual(error,e);
+}
+})();