worker: send correct error status for worker init

When the worker is created, in case of failure when a separate isolate is not able to get created, we tend to throw out of memory error for that worker which is not the case. Correct error code as per semantic should be thrown which is in our case is `ERR_WORKER_INIT_FAILED`. PR-URL: #36242 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Juan José Arboleda <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

Author: yashLadha

src/node_worker.cc

@@ -150,9 +150,7 @@ class WorkerThreadData{
 
  Isolate* isolate = Isolate::Allocate();
 if (isolate == nullptr){
-// TODO(addaleax): This should be ERR_WORKER_INIT_FAILED,
-// ERR_WORKER_OUT_OF_MEMORY is for reaching the per-Worker heap limit.
- w->Exit(1, "ERR_WORKER_OUT_OF_MEMORY", "Failed to create new Isolate");
+ w->Exit(1, "ERR_WORKER_INIT_FAILED", "Failed to create new Isolate");
 return;
  }
 
@@ -298,9 +296,7 @@ void Worker::Run(){
  TryCatch try_catch(isolate_);
  context = NewContext(isolate_);
 if (context.IsEmpty()){
-// TODO(addaleax): This should be ERR_WORKER_INIT_FAILED,
-// ERR_WORKER_OUT_OF_MEMORY is for reaching the per-Worker heap limit.
-Exit(1, "ERR_WORKER_OUT_OF_MEMORY", "Failed to create new Context");
+Exit(1, "ERR_WORKER_INIT_FAILED", "Failed to create new Context");
 return;
  }
  }