test: ensure assertions are reachable in test/sequential

PR-URL: #60412 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>

Author: aduh95

test/eslint.config_partial.mjs

@@ -177,6 +177,7 @@ export default [
 'pummel',
 'report',
 'sea',
+'sequential',
 'sqlite',
 'system-ca',
 'test426',

test/sequential/test-child-process-execsync.js

@@ -147,9 +147,9 @@ const args = [
 assert.strictEqual(typeoferr.pid,'number');
 spawnSyncKeys
 .filter((key)=>key!=='pid')
-.forEach((key)=>{
+.forEach(common.mustCallAtLeast((key)=>{
 assert.deepStrictEqual(err[key],spawnSyncResult[key]);
-});
+}));
 returntrue;
 });
 }

test/sequential/test-child-process-pass-fd.js

@@ -21,7 +21,7 @@ const N = 80;
 letmessageCallbackCount=0;
 
 functionforkWorker(){
-constmessageCallback=(msg,handle)=>{
+constmessageCallback=common.mustCall((msg,handle)=>{
 messageCallbackCount++;
 assert.strictEqual(msg,'handle');
 assert.ok(handle);
@@ -32,11 +32,11 @@ function forkWorker(){
 recvData+=data;
 }));
 
-handle.on('end',()=>{
+handle.on('end',common.mustCall(()=>{
 assert.strictEqual(recvData,'hello');
 worker.kill();
-});
-};
+}));
+});
 
 constworker=fork(__filename,['child']);
 worker.on('error',(err)=>{
@@ -70,13 +70,13 @@ if (process.argv[2] !== 'child'){
 // thus no work to do, and will exit immediately, preventing process leaks.
 process.on('message',common.mustCall());
 
-constserver=net.createServer((c)=>{
-process.once('message',(msg)=>{
+constserver=net.createServer(common.mustCall((c)=>{
+process.once('message',common.mustCall((msg)=>{
 assert.strictEqual(msg,'got');
 c.end('hello');
-});
+}));
 socketConnected();
-}).unref();
+})).unref();
 server.listen(0,common.localhostIPv4,()=>{
 const{ port }=server.address();
 socket=net.connect(port,common.localhostIPv4,socketConnected).unref();

test/sequential/test-cluster-send-handle-large-payload.js

@@ -23,10 +23,9 @@ if (cluster.isPrimary){
 server.listen(0,common.mustCall(()=>{
 constport=server.address().port;
 constsocket=newnet.Socket();
-socket.connect(port,(err)=>{
-assert.ifError(err);
+socket.connect(port,common.mustSucceed(()=>{
 worker.send({ payload },socket);
-});
+}));
 }));
 }else{
 process.on('message',common.mustCall(({payload: received},handle)=>{

test/sequential/test-debugger-pid.js

@@ -11,7 +11,7 @@ const{spawn } = require('child_process');
 
 constscript=fixtures.path('debugger','alive.js');
 
-construnTest=async()=>{
+(async()=>{
 consttarget=spawn(process.execPath,[script]);
 constcli=startCLI(['-p',`${target.pid}`],[],{},{randomPort: false});
 
@@ -24,12 +24,8 @@ const runTest = async () =>{
 cli.output,
 />3{3}\+\+x;/,
 'marks the 3rd line');
-}catch(error){
-assert.ifError(error);
 }finally{
 awaitcli.quit();
 target.kill();
 }
-};
-
-runTest().then(common.mustCall());
+})().then(common.mustCall());

test/sequential/test-deprecation-flags.js

@@ -20,7 +20,7 @@
 // USE OR OTHER DEALINGS IN THE SOFTWARE.
 
 'use strict';
-require('../common');
+constcommon=require('../common');
 constfixtures=require('../common/fixtures');
 constassert=require('assert');
 constexecFile=require('child_process').execFile;
@@ -40,49 +40,43 @@ const normal = [depmod];
 constnoDep=['--no-deprecation',depmod];
 consttraceDep=['--trace-deprecation',depmod];
 
-execFile(node,normal,function(er,stdout,stderr){
+execFile(node,normal,common.mustSucceed((stdout,stderr)=>{
 console.error('normal: show deprecation warning');
-assert.strictEqual(er,null);
 assert.strictEqual(stdout,'');
 assert.match(stderr,/thisfunctionisdeprecated/);
 console.log('normal ok');
-});
+}));
 
-execFile(node,noDep,function(er,stdout,stderr){
+execFile(node,noDep,common.mustSucceed((stdout,stderr)=>{
 console.error('--no-deprecation: silence deprecations');
-assert.strictEqual(er,null);
 assert.strictEqual(stdout,'');
 assert.strictEqual(stderr.trim(),'This is deprecated');
 console.log('silent ok');
-});
+}));
 
-execFile(node,traceDep,function(er,stdout,stderr){
+execFile(node,traceDep,common.mustSucceed((stdout,stderr)=>{
 console.error('--trace-deprecation: show stack');
-assert.strictEqual(er,null);
 assert.strictEqual(stdout,'');
 conststack=stderr.trim().split('\n');
 // Just check the top and bottom.
 assert.match(stack[1],/thisfunctionisdeprecated/);
 assert.match(stack[0],/Thisisdeprecated/);
 console.log('trace ok');
-});
+}));
 
-execFile(node,[depUserlandFunction],function(er,stdout,stderr){
+execFile(node,[depUserlandFunction],common.mustSucceed((stdout,stderr)=>{
 console.error('normal: testing deprecated userland function');
-assert.strictEqual(er,null);
 assert.strictEqual(stdout,'');
 assert.match(stderr,/deprecatedFunctionisdeprecated/);
 console.error('normal: ok');
-});
+}));
 
-execFile(node,[depUserlandClass],function(er,stdout,stderr){
-assert.strictEqual(er,null);
+execFile(node,[depUserlandClass],common.mustSucceed((stdout,stderr)=>{
 assert.strictEqual(stdout,'');
 assert.match(stderr,/deprecatedClassisdeprecated/);
-});
+}));
 
-execFile(node,[depUserlandSubClass],function(er,stdout,stderr){
-assert.strictEqual(er,null);
+execFile(node,[depUserlandSubClass],common.mustSucceed((stdout,stderr)=>{
 assert.strictEqual(stdout,'');
 assert.match(stderr,/deprecatedClassisdeprecated/);
-});
+}));

test/sequential/test-dgram-pingpong.js

@@ -14,17 +14,17 @@ function pingPongTest(port, host){
 throwe;
 });
 
-server.on('listening',function(){
+server.on('listening',common.mustCall(()=>{
 console.log(`server listening on ${port}`);
 
 constclient=dgram.createSocket('udp4');
 
-client.on('message',function(msg){
+client.on('message',common.mustCall((msg)=>{
 assert.strictEqual(msg.toString('ascii'),'PONG');
 
 client.close();
 server.close();
-});
+}));
 
 client.on('error',function(e){
 throwe;
@@ -37,7 +37,7 @@ function pingPongTest(port, host){
 }
 
 clientSend();
-});
+}));
 server.bind(port,host);
 returnserver;
 }

test/sequential/test-fs-readdir-recursive.js

@@ -134,11 +134,11 @@ function assertDirents(dirents){
 assert.strictEqual(dirents.length,expected.length);
 dirents.sort((a,b)=>(getDirentPath(a)<getDirentPath(b) ? -1 : 1));
 assert.deepStrictEqual(
-dirents.map((dirent)=>{
+dirents.map(common.mustCallAtLeast((dirent)=>{
 assert(direntinstanceoffs.Dirent);
 assert.notStrictEqual(dirent.name,undefined);
 returngetDirentPath(dirent);
-}),
+})),
 expected
 );
 }

test/sequential/test-heapdump-flag-custom-dir.js

@@ -7,7 +7,7 @@ if (common.isWindows)
 
 constassert=require('assert');
 
-constvalidateHeapSnapshotFile=()=>{
+if(process.argv[2]==='child'){
 constfs=require('fs');
 
 assert.strictEqual(process.listenerCount('SIGUSR2'),1);
@@ -31,10 +31,6 @@ const validateHeapSnapshotFile = () =>{
 JSON.parse(fs.readFileSync(files[i]));
 }
 })();
-};
-
-if(process.argv[2]==='child'){
-validateHeapSnapshotFile();
 }else{
 // Modify the timezone. So we can check the file date string still returning correctly.
 process.env.TZ='America/New_York';

test/sequential/test-http-econnrefused.js

@@ -32,20 +32,20 @@ const common = require('../common');
 consthttp=require('http');
 constassert=require('assert');
 
-constserver=http.createServer(function(req,res){
+constserver=http.createServer(common.mustCallAtLeast((req,res)=>{
 letbody='';
 
 req.setEncoding('utf8');
 req.on('data',function(chunk){
 body+=chunk;
 });
 
-req.on('end',function(){
+req.on('end',common.mustCall(()=>{
 assert.strictEqual(body,'PING');
 res.writeHead(200,{'Connection': 'close'});
 res.end('PONG');
-});
-});
+}));
+}));
 
 
 server.on('listening',pingping);
@@ -109,36 +109,36 @@ function ping(){
 method: 'POST'
 };
 
-constreq=http.request(opt,function(res){
+constreq=http.request(opt,common.mustCallAtLeast((res)=>{
 letbody='';
 
 res.setEncoding('utf8');
 res.on('data',function(chunk){
 body+=chunk;
 });
 
-res.on('end',function(){
+res.on('end',common.mustCall(()=>{
 assert.strictEqual(body,'PONG');
 assert.ok(!hadError);
 gotEnd=true;
 afterPing('success');
-});
-});
+}));
+},0));
 
 req.end('PING');
 
 letgotEnd=false;
 lethadError=false;
 
-req.on('error',function(error){
+req.on('error',common.mustCallAtLeast((error)=>{
 console.log(`Error making ping req: ${error}`);
 hadError=true;
 assert.ok(!gotEnd);
 
 // Family autoselection might be skipped if only a single address is returned by DNS.
 constactualError=Array.isArray(error.errors) ? error.errors[0] : error;
 afterPing(actualError.message);
-});
+},0));
 }