fs: improve error performance of readvSync

PR-URL: #50100 Refs: nodejs/performance#106 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

Author: IlyasShabi

benchmark/fs/bench-readvSync.js

@@ -0,0 +1,58 @@
+'use strict';
+
+constcommon=require('../common');
+constfs=require('fs');
+constassert=require('assert');
+consttmpdir=require('../../test/common/tmpdir');
+tmpdir.refresh();
+
+constexptectedBuff=Buffer.from('Benchmark Data');
+constexpectedLength=exptectedBuff.length;
+
+constbufferArr=[Buffer.alloc(expectedLength)];
+
+constfilename=tmpdir.resolve('readv_sync.txt');
+fs.writeFileSync(filename,exptectedBuff);
+
+constbench=common.createBenchmark(main,{
+type: ['valid','invalid'],
+n: [1e5],
+});
+
+functionmain({ n, type }){
+letfd;
+letresult;
+
+switch(type){
+case'valid':
+fd=fs.openSync(filename,'r');
+
+bench.start();
+for(leti=0;i<n;i++){
+result=fs.readvSync(fd,bufferArr,0);
+}
+
+bench.end(n);
+assert.strictEqual(result,expectedLength);
+fs.closeSync(fd);
+break;
+case'invalid': {
+fd=1<<30;
+lethasError=false;
+bench.start();
+for(leti=0;i<n;i++){
+try{
+result=fs.readvSync(fd,bufferArr,0);
+}catch{
+hasError=true;
+}
+}
+
+bench.end(n);
+assert(hasError);
+break;
+}
+default:
+thrownewError('Invalid type');
+}
+}

lib/fs.js

@@ -801,14 +801,10 @@ function readvSync(fd, buffers, position){
 fd=getValidatedFd(fd);
 validateBufferArray(buffers);
 
-constctx={};
-
 if(typeofposition!=='number')
 position=null;
 
-constresult=binding.readBuffers(fd,buffers,position,undefined,ctx);
-handleErrorFromBinding(ctx);
-returnresult;
+returnbinding.readBuffers(fd,buffers,position);
 }
 
 /**

src/node_file.cc

@@ -2564,18 +2564,20 @@ static void ReadBuffers(const FunctionCallbackInfo<Value>& args){
  iovs[i] = uv_buf_init(Buffer::Data(buffer), Buffer::Length(buffer));
  }
 
-FSReqBase* req_wrap_async = GetReqWrap(args, 3);
-if (req_wrap_async != nullptr){// readBuffers(fd, buffers, pos, req)
+if (argc > 3){// readBuffers(fd, buffers, pos, req)
+ FSReqBase* req_wrap_async = GetReqWrap(args, 3);
 FS_ASYNC_TRACE_BEGIN0(UV_FS_READ, req_wrap_async)
 AsyncCall(env, req_wrap_async, args, "read", UTF8, AfterInteger,
  uv_fs_read, fd, *iovs, iovs.length(), pos);
  } else{// readBuffers(fd, buffers, undefined, ctx)
-CHECK_EQ(argc, 5);
- FSReqWrapSync req_wrap_sync;
+ FSReqWrapSync req_wrap_sync("read");
 FS_SYNC_TRACE_BEGIN(read);
-int bytesRead = SyncCall(env, /* ctx */ args[4], &req_wrap_sync, "read",
- uv_fs_read, fd, *iovs, iovs.length(), pos);
+int bytesRead = SyncCallAndThrowOnError(
+env, &req_wrap_sync, uv_fs_read, fd, *iovs, iovs.length(), pos);
 FS_SYNC_TRACE_END(read, "bytesRead", bytesRead);
+if (is_uv_error(bytesRead)){
+return;
+ }
  args.GetReturnValue().Set(bytesRead);
  }
 }