test: use Countdown in test-http-set-cookies

shilomagen · gibfahn · commit 68dabce07a9e · 2017-12-20T00:57:10.000Z
PR-URL: #17504 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
diff --git a/test/parallel/test-http-set-cookies.js b/test/parallel/test-http-set-cookies.js
@@ -2,9 +2,9 @@
 require('../common');
 const assert = require('assert');
 const http = require('http');
+const Countdown = require('../common/countdown');
 
-let nresponses = 0;
-
+const countdown = new Countdown(2, () => server.close());
 const server = http.createServer(function(req, res){
 if (req.url === '/one'){
 res.writeHead(200, [['set-cookie', 'A'],
@@ -34,9 +34,7 @@ server.on('listening', function(){
 });
 
 res.on('end', function(){
- if (++nresponses === 2){
- server.close();
- }
+ countdown.dec();
 });
 });
 
@@ -51,14 +49,8 @@ server.on('listening', function(){
 });
 
 res.on('end', function(){
- if (++nresponses === 2){
- server.close();
- }
+ countdown.dec();
 });
 });
 
 });
-
-process.on('exit', function(){
- assert.strictEqual(2, nresponses);
-});

-Original file line number
+Diff line change
 require('../common');
 constassert=require('assert');
 consthttp=require('http');
 +constCountdown=require('../common/countdown');
 -letnresponses=0;
+-
 +constcountdown=newCountdown(2,()=>server.close());
 constserver=http.createServer(function(req,res){
 if(req.url==='/one'){
 res.writeHead(200,[['set-cookie','A'],
 });
 res.on('end',function(){
 -if(++nresponses===2){
 -server.close();
 -}
 +countdown.dec();
 });
 });
 });
 res.on('end',function(){
 -if(++nresponses===2){
 -server.close();
 -}
 +countdown.dec();
 });
 });
 });
+-
 -process.on('exit',function(){
 -assert.strictEqual(2,nresponses);
 -});