test: add test for position validation in fs.read() and fs.readSync()

PR-URL: #42837 Co-authored-by: Antoine du Hamel <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]>

Author: 2 people

test/parallel/test-fs-read-position-validation.mjs

@@ -0,0 +1,133 @@
+import*ascommonfrom'../common/index.mjs';
+import*asfixturesfrom'../common/fixtures.mjs';
+importfsfrom'fs';
+importassertfrom'assert';
+
+// This test ensures that "position" argument is correctly validated
+
+constfilepath=fixtures.path('x.txt');
+
+constbuffer=Buffer.from('xyz\n');
+constoffset=0;
+constlength=buffer.byteLength;
+
+// allowedErrors is an array of acceptable internal errors
+// For example, on some platforms read syscall might return -EFBIG
+asyncfunctiontestValid(position,allowedErrors=[]){
+letfdSync;
+try{
+fdSync=fs.openSync(filepath,'r');
+fs.readSync(fdSync,buffer,offset,length,position);
+fs.readSync(fdSync,buffer,{ offset, length, position });
+}catch(err){
+if(!allowedErrors.includes(err.code)){
+assert.fail(err);
+}
+}finally{
+if(fdSync)fs.closeSync(fdSync);
+}
+
+fs.open(filepath,'r',common.mustSucceed((fd)=>{
+try{
+if(allowedErrors.length){
+fs.read(fd,buffer,offset,length,position,common.mustCall((err, ...results)=>{
+if(err&&!allowedErrors.includes(err.code)){
+assert.fail(err);
+}
+}));
+fs.read(fd,{ buffer, offset, length, position },common.mustCall((err, ...results)=>{
+if(err&&!allowedErrors.includes(err.code)){
+assert.fail(err);
+}
+}));
+}else{
+fs.read(fd,buffer,offset,length,position,common.mustSucceed());
+fs.read(fd,{ buffer, offset, length, position },common.mustSucceed());
+}
+}finally{
+fs.close(fd,common.mustSucceed());
+}
+}));
+}
+
+asyncfunctiontestInvalid(code,position,internalCatch=false){
+letfdSync;
+try{
+fdSync=fs.openSync(filepath,'r');
+assert.throws(
+()=>fs.readSync(fdSync,buffer,offset,length,position),
+{ code }
+);
+assert.throws(
+()=>fs.readSync(fdSync,buffer,{ offset, length, position }),
+{ code }
+);
+}finally{
+if(fdSync)fs.closeSync(fdSync);
+}
+
+// Set this flag for catching errors via first argument of callback function
+if(internalCatch){
+fs.open(filepath,'r',common.mustSucceed((fd)=>{
+try{
+fs.read(fd,buffer,offset,length,position,(err, ...results)=>{
+assert.strictEqual(err.code,code);
+});
+fs.read(fd,{ buffer, offset, length, position },(err, ...results)=>{
+assert.strictEqual(err.code,code);
+});
+}finally{
+fs.close(fd,common.mustSucceed());
+}
+}));
+}else{
+fs.open(filepath,'r',common.mustSucceed((fd)=>{
+try{
+assert.throws(
+()=>fs.read(fd,buffer,offset,length,position,common.mustNotCall()),
+{ code }
+);
+assert.throws(
+()=>fs.read(fd,{ buffer, offset, length, position },common.mustNotCall()),
+{ code }
+);
+}finally{
+fs.close(fd,common.mustSucceed());
+}
+}));
+}
+}
+
+{
+awaittestValid(undefined);
+awaittestValid(null);
+awaittestValid(-1);
+awaittestValid(-1n);
+
+awaittestValid(0);
+awaittestValid(0n);
+awaittestValid(1);
+awaittestValid(1n);
+awaittestValid(9);
+awaittestValid(9n);
+awaittestValid(Number.MAX_SAFE_INTEGER,['EFBIG']);
+
+awaittestValid(2n**63n-1n-BigInt(length),['EFBIG']);
+awaittestInvalid('ERR_OUT_OF_RANGE',2n**63n);
+
+// TODO(LiviaMedeiros): test `2n ** 63n - BigInt(length)`
+
+awaittestInvalid('ERR_OUT_OF_RANGE',NaN);
+awaittestInvalid('ERR_OUT_OF_RANGE',-Infinity);
+awaittestInvalid('ERR_OUT_OF_RANGE',Infinity);
+awaittestInvalid('ERR_OUT_OF_RANGE',-0.999);
+awaittestInvalid('ERR_OUT_OF_RANGE',-(2n**64n));
+awaittestInvalid('ERR_OUT_OF_RANGE',Number.MAX_SAFE_INTEGER+1);
+awaittestInvalid('ERR_OUT_OF_RANGE',Number.MAX_VALUE);
+
+for(constbadTypeValueof[
+false,true,'1',Symbol(1),{},[],()=>{},Promise.resolve(1),
+]){
+awaittestInvalid('ERR_INVALID_ARG_TYPE',badTypeValue);
+}
+}