util: inspect: do not crash on Symbol function names

ljharb · ljharb · commit 6932162f2475 · 2025-01-12T12:48:44.000-08:00
See #56570
diff --git a/lib/internal/util/inspect.js b/lib/internal/util/inspect.js
@@ -1250,7 +1250,7 @@ function getFunctionBase(value, constructor, tag){
 if (value.name === ''){
 base += ' (anonymous)';
 } else{
- base += `: ${value.name}`;
+ base += `: ${typeof value.name === 'symbol' ? inspect(value.name) : value.name}`;
 }
 base += ']';
 if (constructor !== type && constructor !== null){
diff --git a/test/parallel/test-util-inspect.js b/test/parallel/test-util-inspect.js
@@ -3426,3 +3426,13 @@ assert.strictEqual(
 Object.defineProperty(BuiltinPrototype, 'constructor', desc);
 }
 }
+
+{
+ function f(){}
+ Object.defineProperty(f, 'name',{value: Symbol('f') });
+
+ assert.strictEqual(
+ util.inspect(f),
+ '[Function: Symbol(f)]',
+ );
+}

Original file line number	Diff line number	Diff line change
`@@ -1250,7 +1250,7 @@ function getFunctionBase(value, constructor, tag){`
`1250`	`1250`	`if(value.name===''){`
`1251`	`1251`	`base+=' (anonymous)';`
`1252`	`1252`	`}else{`
`1253`		-base+=`: ${value.name}`;
	`1253`	+base+=`: ${typeofvalue.name==='symbol' ? inspect(value.name) : value.name}`;
`1254`	`1254`	`}`
`1255`	`1255`	`base+=']';`
`1256`	`1256`	`if(constructor!==type&&constructor!==null){`
Original file line number	Diff line number	Diff line change
`@@ -3426,3 +3426,13 @@ assert.strictEqual(`
`3426`	`3426`	`Object.defineProperty(BuiltinPrototype,'constructor',desc);`
`3427`	`3427`	`}`
`3428`	`3428`	`}`
	`3429`	`+`
	`3430`	`+{`
	`3431`	`+functionf(){}`
	`3432`	`+Object.defineProperty(f,'name',{value: Symbol('f')});`
	`3433`	`+`
	`3434`	`+assert.strictEqual(`
	`3435`	`+util.inspect(f),`
	`3436`	`+'[Function: Symbol(f)]',`
	`3437`	`+);`
	`3438`	`+}`