tls: check arg types of renegotiate()

Don't throw on invalid property access if options is not provided, and ensure callback is a function. PR-URL: #25876 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>

Author: sam-github

lib/_tls_wrap.js

@@ -39,6 +39,7 @@ const{owner_symbol } = require('internal/async_hooks').symbols;
 const{SecureContext: NativeSecureContext}=internalBinding('crypto');
 const{
 ERR_INVALID_ARG_TYPE,
+ERR_INVALID_CALLBACK,
 ERR_MULTIPLE_CALLBACK,
 ERR_SOCKET_CLOSED,
 ERR_TLS_DH_PARAM_SIZE,
@@ -581,6 +582,11 @@ TLSSocket.prototype._init = function(socket, wrap){
 };
 
 TLSSocket.prototype.renegotiate=function(options,callback){
+if(options===null||typeofoptions!=='object')
+thrownewERR_INVALID_ARG_TYPE('options','Object',options);
+if(callback!=null&&typeofcallback!=='function')
+thrownewERR_INVALID_CALLBACK();
+
 if(this.destroyed)
 return;
 

test/parallel/test-tls-disable-renegotiation.js

@@ -47,6 +47,22 @@ server.listen(0, common.mustCall(() =>{
 };
 constclient=tls.connect(options,common.mustCall(()=>{
 client.write('');
+
+common.expectsError(()=>client.renegotiate(),{
+code: 'ERR_INVALID_ARG_TYPE',
+type: TypeError,
+});
+
+common.expectsError(()=>client.renegotiate(common.mustNotCall()),{
+code: 'ERR_INVALID_ARG_TYPE',
+type: TypeError,
+});
+
+common.expectsError(()=>client.renegotiate({},false),{
+code: 'ERR_INVALID_CALLBACK',
+type: TypeError,
+});
+
 // Negotiation is still permitted for this first
 // attempt. This should succeed.
 letok=client.renegotiate(options,common.mustCall((err)=>{