test: deflake test-tls-passphrase

Move `socket.end()` to client. Fixes: #28111 Refs: #27569 PR-URL: #29134 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: lpinca

test/parallel/test-tls-passphrase.js

@@ -37,15 +37,17 @@ assert(Buffer.isBuffer(cert));
 assert.strictEqual(typeofpassKey.toString(),'string');
 assert.strictEqual(typeofcert.toString(),'string');
 
+functiononSecureConnect(){
+returncommon.mustCall(function(){this.end();});
+}
+
 constserver=tls.Server({
 key: passKey,
 passphrase: 'password',
 cert: cert,
 ca: [cert],
 requestCert: true,
 rejectUnauthorized: true
-},function(s){
-s.end();
 });
 
 server.listen(0,common.mustCall(function(){
@@ -56,22 +58,22 @@ server.listen(0, common.mustCall(function(){
 passphrase: 'password',
 cert: cert,
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 tls.connect({
 port: this.address().port,
 key: rawKey,
 cert: cert,
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 tls.connect({
 port: this.address().port,
 key: rawKey,
 passphrase: 'ignored',
 cert: cert,
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 // Buffer[]
 tls.connect({
@@ -80,22 +82,22 @@ server.listen(0, common.mustCall(function(){
 passphrase: 'password',
 cert: [cert],
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 tls.connect({
 port: this.address().port,
 key: [rawKey],
 cert: [cert],
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 tls.connect({
 port: this.address().port,
 key: [rawKey],
 passphrase: 'ignored',
 cert: [cert],
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 // string
 tls.connect({
@@ -104,22 +106,22 @@ server.listen(0, common.mustCall(function(){
 passphrase: 'password',
 cert: cert.toString(),
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 tls.connect({
 port: this.address().port,
 key: rawKey.toString(),
 cert: cert.toString(),
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 tls.connect({
 port: this.address().port,
 key: rawKey.toString(),
 passphrase: 'ignored',
 cert: cert.toString(),
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 // String[]
 tls.connect({
@@ -128,97 +130,97 @@ server.listen(0, common.mustCall(function(){
 passphrase: 'password',
 cert: [cert.toString()],
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 tls.connect({
 port: this.address().port,
 key: [rawKey.toString()],
 cert: [cert.toString()],
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 tls.connect({
 port: this.address().port,
 key: [rawKey.toString()],
 passphrase: 'ignored',
 cert: [cert.toString()],
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 // Object[]
 tls.connect({
 port: this.address().port,
 key: [{pem: passKey,passphrase: 'password'}],
 cert: cert,
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 tls.connect({
 port: this.address().port,
 key: [{pem: passKey,passphrase: 'password'}],
 passphrase: 'ignored',
 cert: cert,
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 tls.connect({
 port: this.address().port,
 key: [{pem: passKey}],
 passphrase: 'password',
 cert: cert,
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 tls.connect({
 port: this.address().port,
 key: [{pem: passKey.toString(),passphrase: 'password'}],
 cert: cert,
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 tls.connect({
 port: this.address().port,
 key: [{pem: rawKey,passphrase: 'ignored'}],
 cert: cert,
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 tls.connect({
 port: this.address().port,
 key: [{pem: rawKey.toString(),passphrase: 'ignored'}],
 cert: cert,
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 tls.connect({
 port: this.address().port,
 key: [{pem: rawKey}],
 passphrase: 'ignored',
 cert: cert,
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 tls.connect({
 port: this.address().port,
 key: [{pem: rawKey.toString()}],
 passphrase: 'ignored',
 cert: cert,
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 tls.connect({
 port: this.address().port,
 key: [{pem: rawKey}],
 cert: cert,
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 
 tls.connect({
 port: this.address().port,
 key: [{pem: rawKey.toString()}],
 cert: cert,
 rejectUnauthorized: false
-},common.mustCall());
+},onSecureConnect());
 })).unref();
 
 consterrMessagePassword=/baddecrypt/;