Skip to content

Commit 6d0b8de

Browse files
aduh95marco-ippolito
authored andcommitted
test: reduce flakiness of test-assert-esm-cjs-message-verify
PR-URL: #53967Fixes: #53962 Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Geoffrey Booth <[email protected]> Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]>
1 parent edb75ae commit 6d0b8de

File tree

1 file changed

+12
-32
lines changed

1 file changed

+12
-32
lines changed
Lines changed: 12 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -1,51 +1,31 @@
11
'use strict';
22

33
const{ spawnPromisified }=require('../common');
4-
consttmpdir=require('../common/tmpdir');
5-
constassert=require('assert');
6-
const{ writeFileSync, unlink }=require('fs');
7-
const{ describe, after, it }=require('node:test');
8-
9-
tmpdir.refresh();
4+
constassert=require('node:assert');
5+
const{ describe, it }=require('node:test');
106

117
constfileImports={
12-
cjs: 'const assert = require("assert");',
13-
mjs: 'import assert from "assert";',
8+
commonjs: 'const assert = require("assert");',
9+
module: 'import assert from "assert";',
1410
};
1511

16-
constfileNames=[];
17-
18-
for(const[ext,header]ofObject.entries(fileImports)){
19-
constfileName=`test-file.${ext}`;
20-
// Store the generated filesnames in an array
21-
fileNames.push(`${tmpdir.path}/${fileName}`);
22-
23-
writeFileSync(tmpdir.resolve(fileName),`${header}\nassert.ok(0 === 2);`);
24-
}
25-
2612
describe('ensure the assert.ok throwing similar error messages for esm and cjs files',()=>{
27-
constnodejsPath=`${process.execPath}`;
28-
consterrorsMessages=[];
29-
3013
it('should return code 1 for each command',async()=>{
31-
for(constfileNameoffileNames){
32-
const{ stderr, code }=awaitspawnPromisified(nodejsPath,[fileName]);
14+
consterrorsMessages=[];
15+
for(const[inputType,header]ofObject.entries(fileImports)){
16+
const{ stderr, code }=awaitspawnPromisified(process.execPath,[
17+
'--input-type',
18+
inputType,
19+
'--eval',
20+
`${header}\nassert.ok(0 === 2);\n`,
21+
]);
3322
assert.strictEqual(code,1);
3423
// For each error message, filter the lines which will starts with AssertionError
3524
errorsMessages.push(
3625
stderr.split('\n').find((s)=>s.startsWith('AssertionError'))
3726
);
3827
}
39-
});
40-
41-
after(()=>{
4228
assert.strictEqual(errorsMessages.length,2);
4329
assert.deepStrictEqual(errorsMessages[0],errorsMessages[1]);
44-
45-
for(constfileNameoffileNames){
46-
unlink(fileName,()=>{});
47-
}
48-
49-
tmpdir.refresh();
5030
});
5131
});

0 commit comments

Comments
(0)