test: remove err timer from test-http-set-timeout

Removed the errorTimer from test-http-set-timeout.js, as this timer is not necessary to test the setTimeout functionality. Also edited the console.log message on line 8 to log the correct timeout duration. Changed var to const, and added common.mustCall() to on timeout and on error callbacks. Fixes: #9256 PR-URL: #9264 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: BethGriggs

test/parallel/test-http-set-timeout.js

@@ -1,32 +1,26 @@
 'use strict';
-varcommon=require('../common');
-varassert=require('assert');
-varhttp=require('http');
-varnet=require('net');
+constcommon=require('../common');
+constassert=require('assert');
+consthttp=require('http');
+constnet=require('net');
 
 varserver=http.createServer(function(req,res){
-console.log('got request. setting 1 second timeout');
-vars=req.connection.setTimeout(500);
-assert.ok(sinstanceofnet.Socket);
-req.connection.on('timeout',function(){
+console.log('got request. setting 500ms timeout');
+varsocket=req.connection.setTimeout(500);
+assert.ok(socketinstanceofnet.Socket);
+req.connection.on('timeout',common.mustCall(function(){
 req.connection.destroy();
 console.error('TIMEOUT');
 server.close();
-});
+}));
 });
 
 server.listen(0,function(){
 console.log(`Server running at http://127.0.0.1:${this.address().port}/`);
 
-varerrorTimer=setTimeout(function(){
-thrownewError('Timeout was not successful');
-},common.platformTimeout(2000));
-
-varx=http.get({port: this.address().port,path: '/'});
-x.on('error',function(){
-clearTimeout(errorTimer);
+varrequest=http.get({port: this.address().port,path: '/'});
+request.on('error',common.mustCall(function(){
 console.log('HTTP REQUEST COMPLETE (this is good)');
-});
-x.end();
-
+}));
+request.end();
 });