test: improve test-net-socket-timeout

* Check for custom Node.js code rather than constructor in assert.throws(). * Use arrow functions consistently. PR-URL: #24859 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>

Author: Trott

test/parallel/test-net-socket-timeout.js

@@ -34,25 +34,25 @@ const validDelays = [0, 0.001, 1, 1e6];
 
 
 for(leti=0;i<nonNumericDelays.length;i++){
-assert.throws(function(){
+assert.throws(()=>{
 s.setTimeout(nonNumericDelays[i],()=>{});
-},TypeError,nonNumericDelays[i]);
+},{code: 'ERR_INVALID_ARG_TYPE'},nonNumericDelays[i]);
 }
 
 for(leti=0;i<badRangeDelays.length;i++){
-assert.throws(function(){
+assert.throws(()=>{
 s.setTimeout(badRangeDelays[i],()=>{});
-},RangeError,badRangeDelays[i]);
+},{code: 'ERR_OUT_OF_RANGE'},badRangeDelays[i]);
 }
 
 for(leti=0;i<validDelays.length;i++){
 s.setTimeout(validDelays[i],()=>{});
 }
 
 constserver=net.Server();
-server.listen(0,common.mustCall(function(){
-constsocket=net.createConnection(this.address().port);
-socket.setTimeout(1,common.mustCall(function(){
+server.listen(0,common.mustCall(()=>{
+constsocket=net.createConnection(server.address().port);
+socket.setTimeout(1,common.mustCall(()=>{
 socket.destroy();
 server.close();
 }));