deps: uvwasi: cherry-pick 75b389c

Original commit message: This commit changes the memory management in uvwasi_fd_table_init() such that ENOMEM errors can be handled better in uvwasi_fd_table_free(). PR-URL: #31076 Reviewed-By: Jiawen Geng <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Rich Trott <[email protected]>

Author: cjihrig

deps/uvwasi/src/fd_table.c

@@ -291,19 +291,25 @@ uvwasi_errno_t uvwasi_fd_table_init(uvwasi_t* uvwasi,
 returnUVWASI_EINVAL;
 
 table->fds=NULL;
-r=uv_rwlock_init(&table->rwlock);
-if (r!=0)
-returnuvwasi__translate_uv_error(r);
-
 table->used=0;
 table->size=init_size;
 table->fds=uvwasi__calloc(uvwasi,
 init_size,
 sizeof(structuvwasi_fd_wrap_t*));
 
-if (table->fds==NULL){
-err=UVWASI_ENOMEM;
- goto error_exit;
+if (table->fds==NULL)
+returnUVWASI_ENOMEM;
+
+r=uv_rwlock_init(&table->rwlock);
+if (r!=0){
+err=uvwasi__translate_uv_error(r);
+/* Free table->fds and set it to NULL here. This is done explicitly instead
+ of jumping to error_exit because uvwasi_fd_table_free() relies on fds
+ being NULL to know whether or not to destroy the rwlock.
+ */
+uvwasi__free(uvwasi, table->fds);
+table->fds=NULL;
+returnerr;
  }
 
 /* Create the stdio FDs. */
@@ -358,13 +364,6 @@ void uvwasi_fd_table_free(uvwasi_t* uvwasi, struct uvwasi_fd_table_t* table){
  }
 
 if (table->fds!=NULL){
-/* It's fine to call uvwasi__free() multiple times on table->fds. However,
- it is not fine to call uv_rwlock_destroy() multiple times. Guard against
- that by ensuring that table->fds is not NULL. Technically, it's possible
- that uvwasi_fd_table_init() initialized the rwlock successfully, but
- failed to initialize fds. However, the only way that's possible is if
- the application already ran out of memory.
- */
 uvwasi__free(uvwasi, table->fds);
 table->fds=NULL;
 table->size=0;