test: fix flaky test-net-GH-5504

santigimeno · evanlucas · commit 6eb6816e22f3 · 2016-11-07T15:58:08.000-06:00
The test is failing on `SmartOS` quite often. Removing the timeout seems to fix it. Fixes: #8930 PR-URL: #9461 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
diff --git a/test/sequential/test-net-GH-5504.js b/test/sequential/test-net-GH-5504.js
@@ -48,14 +48,6 @@ function parent(){
 var spawn = require('child_process').spawn;
 var node = process.execPath;
 
- setTimeout(function(){
- if (s) s.kill();
- if (c) c.kill();
- setTimeout(function(){
- throw new Error('hang');
- });
- }, common.platformTimeout(2000)).unref();
-
 var s = spawn(node, [__filename, 'server'],{
 env: Object.assign(process.env,{
 NODE_DEBUG: 'net'

-Original file line number
+Diff line change
 varspawn=require('child_process').spawn;
 varnode=process.execPath;
 -setTimeout(function(){
 -if(s)s.kill();
 -if(c)c.kill();
 -setTimeout(function(){
 -thrownewError('hang');
 -});
 -},common.platformTimeout(2000)).unref();
+-
 vars=spawn(node,[__filename,'server'],{
 env: Object.assign(process.env,{
 NODE_DEBUG: 'net'