dns: update lookupService() first arg name

The first argument to lookupService() should be an IP address, and is named "address" in the documentation. This commit updates the code to match the documentation and provide less confusing errors. PR-URL: #29040Fixes: #29039 Reviewed-By: Rich Trott <[email protected]> Reviewed-By: Sam Roberts <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Author: cjihrig

lib/dns.js

@@ -164,13 +164,12 @@ function onlookupservice(err, hostname, service){
 }
 
 
-// lookupService(address, port, callback)
-functionlookupService(hostname,port,callback){
+functionlookupService(address,port,callback){
 if(arguments.length!==3)
-thrownewERR_MISSING_ARGS('hostname','port','callback');
+thrownewERR_MISSING_ARGS('address','port','callback');
 
-if(isIP(hostname)===0)
-thrownewERR_INVALID_OPT_VALUE('hostname',hostname);
+if(isIP(address)===0)
+thrownewERR_INVALID_OPT_VALUE('address',address);
 
 if(!isLegalPort(port))
 thrownewERR_SOCKET_BAD_PORT(port);
@@ -182,12 +181,12 @@ function lookupService(hostname, port, callback){
 
 constreq=newGetNameInfoReqWrap();
 req.callback=callback;
-req.hostname=hostname;
+req.hostname=address;
 req.port=port;
 req.oncomplete=onlookupservice;
 
-consterr=cares.getnameinfo(req,hostname,port);
-if(err)throwdnsException(err,'getnameinfo',hostname);
+consterr=cares.getnameinfo(req,address,port);
+if(err)throwdnsException(err,'getnameinfo',address);
 returnreq;
 }
 

lib/internal/dns/promises.js

@@ -151,17 +151,17 @@ function createLookupServicePromise(hostname, port){
 });
 }
 
-functionlookupService(hostname,port){
+functionlookupService(address,port){
 if(arguments.length!==2)
-thrownewERR_MISSING_ARGS('hostname','port');
+thrownewERR_MISSING_ARGS('address','port');
 
-if(isIP(hostname)===0)
-thrownewERR_INVALID_OPT_VALUE('hostname',hostname);
+if(isIP(address)===0)
+thrownewERR_INVALID_OPT_VALUE('address',address);
 
 if(!isLegalPort(port))
 thrownewERR_SOCKET_BAD_PORT(port);
 
-returncreateLookupServicePromise(hostname,+port);
+returncreateLookupServicePromise(address,+port);
 }
 
 

test/parallel/test-dns.js

@@ -265,29 +265,29 @@ dns.lookup('',{
 consterr={
 code: 'ERR_MISSING_ARGS',
 type: TypeError,
-message: 'The "hostname", "port", and "callback" arguments must be '+
+message: 'The "address", "port", and "callback" arguments must be '+
 'specified'
 };
 
 common.expectsError(()=>dns.lookupService('0.0.0.0'),err);
-err.message='The "hostname" and "port" arguments must be specified';
+err.message='The "address" and "port" arguments must be specified';
 common.expectsError(()=>dnsPromises.lookupService('0.0.0.0'),err);
 }
 
 {
-constinvalidHost='fasdfdsaf';
+constinvalidAddress='fasdfdsaf';
 consterr={
 code: 'ERR_INVALID_OPT_VALUE',
 type: TypeError,
-message: `The value "${invalidHost}" is invalid for option "hostname"`
+message: `The value "${invalidAddress}" is invalid for option "address"`
 };
 
 common.expectsError(()=>{
-dnsPromises.lookupService(invalidHost,0);
+dnsPromises.lookupService(invalidAddress,0);
 },err);
 
 common.expectsError(()=>{
-dns.lookupService(invalidHost,0,common.mustNotCall());
+dns.lookupService(invalidAddress,0,common.mustNotCall());
 },err);
 }