fs: remove unneeded return statement

lpinca · lpinca · commit 6fb96bbd3fa2 · 2023-06-22T21:59:19.000+02:00
The `writable._write()` implementation does not need to return anything,
only call the callback.
diff --git a/lib/internal/fs/sync_write_stream.js b/lib/internal/fs/sync_write_stream.js
@@ -25,7 +25,6 @@ ObjectSetPrototypeOf(SyncWriteStream, Writable);
 SyncWriteStream.prototype._write = function(chunk, encoding, cb){
 writeSync(this.fd, chunk, 0, chunk.length);
 cb();
- return true;
 };
 
 SyncWriteStream.prototype._destroy = function(err, cb){
diff --git a/test/parallel/test-internal-fs-syncwritestream.js b/test/parallel/test-internal-fs-syncwritestream.js
@@ -36,7 +36,12 @@ const filename = path.join(tmpdir.path, 'sync-write-stream.txt');
 const stream = new SyncWriteStream(fd);
 const chunk = Buffer.from('foo');
 
- assert.strictEqual(stream._write(chunk, null, common.mustCall(1)), true);
+ let calledSynchronously = false;
+ stream._write(chunk, null, common.mustCall(() =>{
+ calledSynchronously = true;
+ }, 1));
+
+ assert.ok(calledSynchronously);
 assert.strictEqual(fs.readFileSync(filename).equals(chunk), true);
 
 fs.closeSync(fd);

-Original file line number
+Diff line change
 SyncWriteStream.prototype._write=function(chunk,encoding,cb){
 writeSync(this.fd,chunk,0,chunk.length);
 cb();
 -returntrue;
 };
 SyncWriteStream.prototype._destroy=function(err,cb){
-Original file line number
+Diff line change
 conststream=newSyncWriteStream(fd);
 constchunk=Buffer.from('foo');
 -assert.strictEqual(stream._write(chunk,null,common.mustCall(1)),true);
 +letcalledSynchronously=false;
 +stream._write(chunk,null,common.mustCall(()=>{
 +calledSynchronously=true;
 +},1));
++
 +assert.ok(calledSynchronously);
 assert.strictEqual(fs.readFileSync(filename).equals(chunk),true);
 fs.closeSync(fd);