process: ignore asyncId 0 in exception handler

Today, the global uncaught exception handler is the only place where asyncId 0 is not ignored and we still proceed to call emitAfter. This would've already failed one of our correctness tests in async_hooks if not for some other code meant to handle a different edge case. Fixes: #22982 PR-URL: #41424 Reviewed-By: Gerhard Stöbich <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: apapirovski

lib/internal/process/execution.js

@@ -20,7 +20,8 @@ const{
  clearAsyncIdStack,
  hasAsyncIdStack,
  afterHooksExist,
- emitAfter
+ emitAfter,
+ popAsyncContext,
 }=require('internal/async_hooks');
 
 // shouldAbortOnUncaughtToggle is a typed array for faster
@@ -183,7 +184,11 @@ function createOnGlobalUncaughtException(){
 // Emit the after() hooks now that the exception has been handled.
 if(afterHooksExist()){
 do{
-emitAfter(executionAsyncId());
+constasyncId=executionAsyncId();
+if(asyncId===0)
+popAsyncContext(0);
+else
+emitAfter(asyncId);
 }while(hasAsyncIdStack());
 }
 // And completely empty the id stack, including anything that may be

test/async-hooks/init-hooks.js

@@ -168,9 +168,6 @@ class ActivityCollector{
 }
 consterr=newError(`Found a handle whose ${hook}`+
 ' hook was invoked but not its init hook');
-// Don't throw if we see invocations due to an assertion in a test
-// failing since we want to list the assertion failure instead
-if(/process\._fatalException/.test(err.stack))returnnull;
 throwerr;
 }
 returnh;

test/async-hooks/test-unhandled-exception-valid-ids.js

@@ -0,0 +1,17 @@
+'use strict';
+
+constcommon=require('../common');
+constinitHooks=require('./init-hooks');
+
+consthooks=initHooks();
+hooks.enable();
+
+setImmediate(()=>{
+thrownewError();
+});
+
+setTimeout(()=>{
+thrownewError();
+},1);
+
+process.on('uncaughtException',common.mustCall(2));