test: refactor error checks to use assert.ifError/mustSucceed

Replace manual `if (err) assert.fail(err)` and `assert.ok(!err)` with `assert.ifError()` or `common.mustSucceed()` in a few tests to clarify intent and follow project conventions. - test/parallel/test-child-process-send-returns-boolean.js - test/parallel/test-dgram-blocklist.js - test/parallel/test-fs-watchfile.js PR-URL: #59424 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>

Author: KimSH39

test/parallel/test-child-process-send-returns-boolean.js

@@ -33,19 +33,19 @@ const subScript = fixtures.path('child-process-persistent.js');
 
 // Sending a handle and not giving the tickQueue time to acknowledge should
 // create the internal backlog, but leave it empty.
-constrv1=s.send('one',handle,(err)=>{if(err)assert.fail(err);});
+constrv1=s.send('one',handle,assert.ifError);
 assert.strictEqual(rv1,true);
 // Since the first `send` included a handle (should be unacknowledged),
 // we can safely queue up only one more message.
-constrv2=s.send('two',(err)=>{if(err)assert.fail(err);});
+constrv2=s.send('two',assert.ifError);
 assert.strictEqual(rv2,true);
 // The backlog should now be indicate to backoff.
-constrv3=s.send('three',(err)=>{if(err)assert.fail(err);});
+constrv3=s.send('three',assert.ifError);
 assert.strictEqual(rv3,false);
 constrv4=s.send('four',(err)=>{
-if(err)assert.fail(err);
+assert.ifError(err);
 // `send` queue should have been drained.
-constrv5=s.send('5',handle,(err)=>{if(err)assert.fail(err);});
+constrv5=s.send('5',handle,assert.ifError);
 assert.strictEqual(rv5,true);
 
 // End test and cleanup.

test/parallel/test-dgram-blocklist.js

@@ -41,9 +41,13 @@ const net = require('net');
 receiveSocket.bind(0,common.localhostIPv4,common.mustCall(()=>{
 constaddressInfo=receiveSocket.address();
 constclient=dgram.createSocket('udp4');
-client.send('hello',addressInfo.port,addressInfo.address,common.mustCall((err)=>{
-assert.ok(!err);
-client.close();
-}));
+client.send(
+'hello',
+addressInfo.port,
+addressInfo.address,
+common.mustSucceed(()=>{
+client.close();
+})
+);
 }));
 }

test/parallel/test-fs-watchfile.js

@@ -94,9 +94,7 @@ if (common.isLinux || common.isMacOS || common.isWindows){
 }));
 
 constinterval=setInterval(()=>{
-fs.writeFile(path.join(dir,'foo.txt'),'foo',common.mustCall((err)=>{
-if(err)assert.fail(err);
-}));
+fs.writeFile(path.join(dir,'foo.txt'),'foo',common.mustSucceed());
 },1);
 }