module: clarify cjs global-like error on ModuleJobSync

PR-URL: #56491 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Joyee Cheung <[email protected]> Reviewed-By: Jacob Smith <[email protected]>

Author: Ceres6

lib/internal/modules/esm/module_job.js

@@ -65,6 +65,37 @@ const isCommonJSGlobalLikeNotDefinedError = (errorMessage) =>
 (globalLike)=>errorMessage===`${globalLike} is not defined`,
 );
 
+
+/**
+ *
+ * @param{Error} e
+ * @param{string} url
+ * @returns{void}
+ */
+constexplainCommonJSGlobalLikeNotDefinedError=(e,url)=>{
+if(e?.name==='ReferenceError'&&
+isCommonJSGlobalLikeNotDefinedError(e.message)){
+e.message+=' in ES module scope';
+
+if(StringPrototypeStartsWith(e.message,'require ')){
+e.message+=', you can use import instead';
+}
+
+constpackageConfig=
+StringPrototypeStartsWith(url,'file://')&&
+RegExpPrototypeExec(/\.js(\?[^#]*)?(#.*)?$/,url)!==null&&
+require('internal/modules/package_json_reader')
+.getPackageScopeConfig(url);
+if(packageConfig.type==='module'){
+e.message+=
+'\nThis file is being treated as an ES module because it has a '+
+`'.js' file extension and '${packageConfig.pjsonPath}' contains `+
+'"type": "module". To treat it as a CommonJS script, rename it '+
+'to use the \'.cjs\' file extension.';
+}
+}
+};
+
 classModuleJobBase{
 constructor(url,importAttributes,phase,isMain,inspectBrk){
 assert(typeofphase==='number');
@@ -326,27 +357,7 @@ class ModuleJob extends ModuleJobBase{
 try{
 awaitthis.module.evaluate(timeout,breakOnSigint);
 }catch(e){
-if(e?.name==='ReferenceError'&&
-isCommonJSGlobalLikeNotDefinedError(e.message)){
-e.message+=' in ES module scope';
-
-if(StringPrototypeStartsWith(e.message,'require ')){
-e.message+=', you can use import instead';
-}
-
-constpackageConfig=
-StringPrototypeStartsWith(this.module.url,'file://')&&
-RegExpPrototypeExec(/\.js(\?[^#]*)?(#.*)?$/,this.module.url)!==null&&
-require('internal/modules/package_json_reader')
-.getPackageScopeConfig(this.module.url);
-if(packageConfig.type==='module'){
-e.message+=
-'\nThis file is being treated as an ES module because it has a '+
-`'.js' file extension and '${packageConfig.pjsonPath}' contains `+
-'"type": "module". To treat it as a CommonJS script, rename it '+
-'to use the \'.cjs\' file extension.';
-}
-}
+explainCommonJSGlobalLikeNotDefinedError(e,this.module.url);
 throwe;
 }
 return{__proto__: null,module: this.module};
@@ -476,8 +487,13 @@ class ModuleJobSync extends ModuleJobBase{
 thrownewERR_REQUIRE_ASYNC_MODULE(filename,parentFilename);
 }
 setHasStartedUserESMExecution();
-constnamespace=this.module.evaluateSync(filename,parentFilename);
-return{__proto__: null,module: this.module, namespace };
+try{
+constnamespace=this.module.evaluateSync(filename,parentFilename);
+return{__proto__: null,module: this.module, namespace };
+}catch(e){
+explainCommonJSGlobalLikeNotDefinedError(e,this.module.url);
+throwe;
+}
 }
 }
 

test/es-module/test-require-module-error-catching.js

@@ -17,5 +17,5 @@ assert.throws(() =>{
 require('../fixtures/es-modules/reference-error-esm.js');
 },{
 name: 'ReferenceError',
-message: 'exports is not defined'
+message: 'exports is not defined in ES module scope'
 });