crypto: fix DiffieHellman generator validation

PR-URL: #38311Fixes: #38302 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Minwoo Jung <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

Author: eladkishon

lib/internal/crypto/diffiehellman.js

@@ -122,9 +122,9 @@ function DiffieHellman(sizeOrKey, keyEncoding, generator, genEncoding){
 generator=DH_GENERATOR;
 }elseif(typeofgenerator==='number'){
 validateInt32(generator,'generator');
-}elseif(generator!==true){
+}elseif(typeofgenerator==='string'){
 generator=toBuf(generator,genEncoding);
-}else{
+}elseif(!isArrayBufferView(generator)&&!isAnyArrayBuffer(generator)){
 thrownewERR_INVALID_ARG_TYPE(
 'generator',
 ['number','string','ArrayBuffer','Buffer','TypedArray','DataView'],

test/parallel/test-crypto-dh.js

@@ -495,3 +495,7 @@ assert.throws(
 code: 'ERR_INVALID_ARG_TYPE'
 }
 );
+[true,Symbol(),{},()=>{},[]].forEach((generator)=>assert.throws(
+()=>crypto.createDiffieHellman('','base64',generator),
+{code: 'ERR_INVALID_ARG_TYPE'}
+));