src: disallow JS execution during exit()

This is just an extra safeguard – no JS should run once we’ve decided that we are going to shutdown the process, but we’re opening a handle scope in order to access V8, so make sure that our operations do not lead to JS accidentally being run. PR-URL: #35020 Reviewed-By: Gus Caplan <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: David Carlier <[email protected]> Reviewed-By: Shelley Vohr <[email protected]>

Author: addaleax

src/env.cc

@@ -964,6 +964,8 @@ uv_key_t Environment::thread_local_env ={};
 voidEnvironment::Exit(int exit_code){
 if (options()->trace_exit){
  HandleScope handle_scope(isolate());
+ Isolate::DisallowJavascriptExecutionScope disallow_js(
+isolate(), Isolate::DisallowJavascriptExecutionScope::CRASH_ON_FAILURE);
 
 if (is_main_thread()){
 fprintf(stderr, "(node:%d) ", uv_os_getpid());