process: make process.config read only

Author: gribnoysup

lib/internal/bootstrap/node.js

@@ -46,10 +46,8 @@ const{
  JSONParse,
  ObjectDefineProperty,
  ObjectGetPrototypeOf,
- ObjectPreventExtensions,
  ObjectSetPrototypeOf,
- ReflectGet,
- ReflectSet,
+ ObjectFreeze,
  SymbolToStringTag,
  globalThis,
 }=primordials;
@@ -72,75 +70,15 @@ process._exiting = false;
 // process.config is serialized config.gypi
 constnativeModule=internalBinding('native_module');
 
-// TODO(@jasnell): Once this has gone through one full major
-// release cycle, remove the Proxy and setter and update the
-// getter to either return a read-only object or always return
-// a freshly parsed version of nativeModule.config.
-
-constdeprecationHandler={
-warned: false,
-message: 'Setting process.config is deprecated. '+
-'In the future the property will be read-only.',
-code: 'DEP0150',
-maybeWarn(){
-if(!this.warned){
-process.emitWarning(this.message,{
-type: 'DeprecationWarning',
-code: this.code
-});
-this.warned=true;
-}
-},
-
-defineProperty(target,key,descriptor){
-this.maybeWarn();
-returnObjectDefineProperty(target,key,descriptor);
-},
-
-deleteProperty(target,key){
-this.maybeWarn();
-deletetarget[key];
-},
-
-preventExtensions(target){
-this.maybeWarn();
-returnObjectPreventExtensions(target);
-},
-
-set(target,key,value){
-this.maybeWarn();
-returnReflectSet(target,key,value);
-},
-
-get(target,key,receiver){
-constval=ReflectGet(target,key,receiver);
-if(val!=null&&typeofval==='object'){
-// eslint-disable-next-line node-core/prefer-primordials
-returnnewProxy(val,deprecationHandler);
-}
-returnval;
-},
-
-setPrototypeOf(target,proto){
-this.maybeWarn();
-returnObjectSetPrototypeOf(target,proto);
-}
-};
-
-// eslint-disable-next-line node-core/prefer-primordials
-letprocessConfig=newProxy(
-JSONParse(nativeModule.config),
-deprecationHandler);
+constprocessConfig=JSONParse(nativeModule.config,(_key,value)=>{
+returnObjectFreeze(value);
+});
 
 ObjectDefineProperty(process,'config',{
 __proto__: null,
 enumerable: true,
 configurable: true,
 get(){returnprocessConfig;},
-set(value){
-deprecationHandler.maybeWarn();
-processConfig=value;
-}
 });
 
 require('internal/worker/js_transferable').setup();

test/parallel/test-process-config.js

@@ -36,6 +36,16 @@ assert(Object.hasOwn(process, 'config'));
 // Ensure that `process.config` is an Object.
 assert.strictEqual(Object(process.config),process.config);
 
+// Ensure that you can't change config values
+try{
+process.config.variables=42;
+}catch(e){
+assert.strictEqual(
+e.message,
+"Cannot assign to read only property 'variables' of object '#<Object>'"
+);
+}
+
 constconfigPath=path.resolve(__dirname,'..','..','config.gypi');
 
 if(!fs.existsSync(configPath)){