inspector: undici as shared-library should pass tests

Uzlopak · targos · commit 74a09482de5a · 2025-09-10T15:29:07.000+02:00
PR-URL: #59837 Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
diff --git a/test/parallel/test-inspector-network-websocket.js b/test/parallel/test-inspector-network-websocket.js
@@ -11,16 +11,18 @@ const WebSocketServer = require('../common/websocket-server');
 const inspector = require('node:inspector/promises');
 const dc = require('diagnostics_channel');
 
+const nameRE = 'undici' in process.versions ? /^node:internal\/deps\/undici\/undici$/u : /undici/u;
+
 const session = new inspector.Session();
 session.connect();
 
 dc.channel('undici:websocket:socket_error').subscribe((message) =>{
 console.error('WebSocket error:', message);
 });
 
-function findFrameInInitiator(scriptName, initiator){
+function findFrameInInitiator(regex, initiator){
 const frame = initiator.stack.callFrames.find((it) =>{
- return it.url === scriptName;
+ return regex.test(it.url);
 });
 return frame;
 }
@@ -39,7 +41,7 @@ async function test(){
 assert.ok(message.params.requestId);
 assert.strictEqual(typeof message.params.initiator, 'object');
 assert.strictEqual(message.params.initiator.type, 'script');
- assert.ok(findFrameInInitiator('node:internal/deps/undici/undici', message.params.initiator));
+ assert.ok(findFrameInInitiator(nameRE, message.params.initiator));
 requestId = message.params.requestId;
 }));
 

-Original file line number
+Diff line change
 constinspector=require('node:inspector/promises');
 constdc=require('diagnostics_channel');
 +constnameRE='undici'inprocess.versions ? /^node:internal\/deps\/undici\/undici$/u : /undici/u;
++
 constsession=newinspector.Session();
 session.connect();
 dc.channel('undici:websocket:socket_error').subscribe((message)=>{
 console.error('WebSocket error:',message);
 });
 -functionfindFrameInInitiator(scriptName,initiator){
 +functionfindFrameInInitiator(regex,initiator){
 constframe=initiator.stack.callFrames.find((it)=>{
 -returnit.url===scriptName;
 +returnregex.test(it.url);
 });
 returnframe;
+}
 assert.ok(message.params.requestId);
 assert.strictEqual(typeofmessage.params.initiator,'object');
 assert.strictEqual(message.params.initiator.type,'script');
 -assert.ok(findFrameInInitiator('node:internal/deps/undici/undici',message.params.initiator));
 +assert.ok(findFrameInInitiator(nameRE,message.params.initiator));
 requestId=message.params.requestId;
 }));