test: fix flaky test-dgram-empty-packet & friends

* Liberal use of common.mustCall() * Rename test-dgram-empty-packet -> test-dgram-send-empty-packet * Remove use of timers to avoid CI failures like seen in the Ref below: ``` not ok 237 parallel/test-dgram-empty-packet --- duration_ms: 0.717 severity: fail stack: |- ... throw new Error('Timeout'); ^ Error: Timeout at Timeout._onTimeout ... at ontimeout (timers.js:365:14) at tryOnTimeout (timers.js:237:5) at Timer.listOnTimeout (timers.js:207:5) ``` Refs: https://ci.nodejs.org/job/node-test-commit-freebsd/5341/nodes=freebsd11-x64/console: PR-URL: #9724 Reviewed-By: Santiago Gimeno <[email protected]>

Author: Trott

test/parallel/test-dgram-empty-packet.js

@@ -1,24 +1,30 @@
 'use strict';
 
 constcommon=require('../common');
-constassert=require('assert');
-constdgram=require('dgram');
 
 if(common.isOSX){
 common.skip('because of 17894467 Apple bug');
 return;
 }
 
+constassert=require('assert');
+constdgram=require('dgram');
+
 constclient=dgram.createSocket('udp4');
 
+varinterval;
+
 client.on('message',common.mustCall(functiononMessage(buf,info){
 constexpected=Buffer.alloc(0);
 assert.ok(buf.equals(expected),'message was received correctly');
+clearInterval(interval);
 client.close();
 }));
 
-client.on('listening',function(){
-client.send([],this.address().port,common.localhostIPv4);
-});
+client.on('listening',common.mustCall(function(){
+interval=setInterval(function(){
+client.send([],client.address().port,common.localhostIPv4);
+},10);
+}));
 
 client.bind(0);

test/parallel/test-dgram-send-empty-array.js

@@ -1,26 +1,27 @@
 'use strict';
 constcommon=require('../common');
-constdgram=require('dgram');
+constassert=require('assert');
 
 if(common.isOSX){
 common.skip('because of 17894467 Apple bug');
 return;
 }
 
+constdgram=require('dgram');
+
 constclient=dgram.createSocket('udp4');
 
-client.bind(0,function(){
+client.bind(0,common.mustCall(function(){
 constport=this.address().port;
 
-client.on('message',common.mustCall(functiononMessage(buffer,bytes){
-clearTimeout(timer);
+client.on('message',common.mustCall(functiononMessage(buffer){
+assert.strictEqual(buffer.length,0);
+clearInterval(interval);
 client.close();
 }));
 
 constbuf=Buffer.alloc(0);
-client.send(buf,0,0,port,'127.0.0.1',function(err,len){});
-
-consttimer=setTimeout(function(){
-thrownewError('Timeout');
-},common.platformTimeout(200));
-});
+varinterval=setInterval(function(){
+client.send(buf,0,0,port,'127.0.0.1',common.mustCall(function(){}));
+},10);
+}));

test/parallel/test-dgram-send-empty-buffer.js

@@ -0,0 +1,34 @@
+'use strict';
+constcommon=require('../common');
+constassert=require('assert');
+
+if(common.isOSX){
+common.skip('because of 17894467 Apple bug');
+return;
+}
+
+constdgram=require('dgram');
+
+constclient=dgram.createSocket('udp4');
+
+client.bind(0,common.mustCall(function(){
+
+client.on('message',common.mustCall(callback));
+
+constport=this.address().port;
+constbuf=Buffer.alloc(1);
+
+constinterval=setInterval(function(){
+client.send(buf,0,0,port,'127.0.0.1',common.mustCall(callback));
+},10);
+
+functioncallback(firstArg){
+// If client.send() callback, firstArg should be null.
+// If client.on('message') listener, firstArg should be a 0-length buffer.
+if(firstArginstanceofBuffer){
+assert.strictEqual(firstArg.length,0);
+clearInterval(interval);
+client.close();
+}
+}
+}));