crypto: fix output of privateDecrypt with zero-length data

closes#57553closes#57572closes#57558 PR-URL: #57575 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Darshan Sen <[email protected]>

Author: panva

deps/ncrypto/ncrypto.cc

@@ -215,7 +215,7 @@ Buffer<void> DataPointer::release(){
 DataPointer DataPointer::resize(size_t len){
 size_t actual_len = std::min(len_, len);
 auto buf = release();
-if (actual_len == len_) returnDataPointer(buf);
+if (actual_len == len_) returnDataPointer(buf.data, actual_len);
  buf.data = OPENSSL_realloc(buf.data, actual_len);
  buf.len = actual_len;
 returnDataPointer(buf);

test/parallel/test-crypto-oaep-zero-length.js

@@ -0,0 +1,56 @@
+'use strict';
+constcommon=require('../common');
+
+if(!common.hasCrypto)
+common.skip('missing crypto');
+
+constfixtures=require('../common/fixtures');
+constassert=require('assert');
+constcrypto=require('crypto');
+
+const{ subtle }=globalThis.crypto;
+
+// Regression test for https://github.com/nodejs/node/issues/57553.
+{
+constprivateKey=crypto.createPrivateKey(fixtures.readKey('rsa_private.pem','ascii'));
+constpublicKey=crypto.createPublicKey(fixtures.readKey('rsa_public.pem','ascii'));
+
+constdata=Buffer.alloc(0);
+{
+
+constciphertext=crypto.publicEncrypt({
+padding: crypto.constants.RSA_PKCS1_OAEP_PADDING,
+key: publicKey,
+},data);
+
+constplaintext=crypto.privateDecrypt({
+padding: crypto.constants.RSA_PKCS1_OAEP_PADDING,
+key: privateKey
+},ciphertext);
+
+assert.deepStrictEqual(plaintext,data);
+}
+
+{
+constciphertext=crypto.publicEncrypt(publicKey,data);
+constplaintext=crypto.privateDecrypt(privateKey,ciphertext);
+
+assert.deepStrictEqual(plaintext,data);
+}
+
+{
+(async()=>{
+constpkcs8=privateKey.export({format: 'der',type: 'pkcs8'});
+constspki=publicKey.export({format: 'der',type: 'spki'});
+
+constkp={
+privateKey: awaitsubtle.importKey('pkcs8',pkcs8,{name: 'RSA-OAEP',hash: 'SHA-1'},false,['decrypt']),
+publicKey: awaitsubtle.importKey('spki',spki,{name: 'RSA-OAEP',hash: 'SHA-1'},false,['encrypt']),
+};
+
+constciphertext=awaitsubtle.encrypt('RSA-OAEP',kp.publicKey,data);
+constplaintext=awaitsubtle.decrypt('RSA-OAEP',kp.privateKey,ciphertext);
+assert.deepStrictEqual(plaintext,data.buffer);
+})().then(common.mustCall());
+}
+}