crypto: handle exceptions in hmac/hash.digest

Forced conversion of the encoding parameter to a string within crypto.js, fixing segmentation faults in node_crypto.cc. Fixes: #9819 PR-URL: #12164 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: tniessen

lib/crypto.js

@@ -78,7 +78,8 @@ Hash.prototype.update = function(data, encoding){
 
 Hash.prototype.digest=function(outputEncoding){
 outputEncoding=outputEncoding||exports.DEFAULT_ENCODING;
-returnthis._handle.digest(outputEncoding);
+// Explicit conversion for backward compatibility.
+returnthis._handle.digest(`${outputEncoding}`);
 };
 
 

src/node.cc

@@ -1483,6 +1483,8 @@ enum encoding ParseEncoding(const char* encoding,
 enum encoding ParseEncoding(Isolate* isolate,
  Local<Value> encoding_v,
 enum encoding default_encoding){
+CHECK(!encoding_v.IsEmpty());
+
 if (!encoding_v->IsString())
 return default_encoding;
 

src/node_crypto.cc

@@ -3783,9 +3783,8 @@ void Hmac::HmacDigest(const FunctionCallbackInfo<Value>& args){
 
 enum encoding encoding = BUFFER;
 if (args.Length() >= 1){
- encoding = ParseEncoding(env->isolate(),
- args[0]->ToString(env->isolate()),
- BUFFER);
+CHECK(args[0]->IsString());
+ encoding = ParseEncoding(env->isolate(), args[0], BUFFER);
  }
 
 unsignedchar* md_value = nullptr;
@@ -3907,9 +3906,8 @@ void Hash::HashDigest(const FunctionCallbackInfo<Value>& args){
 
 enum encoding encoding = BUFFER;
 if (args.Length() >= 1){
- encoding = ParseEncoding(env->isolate(),
- args[0]->ToString(env->isolate()),
- BUFFER);
+CHECK(args[0]->IsString());
+ encoding = ParseEncoding(env->isolate(), args[0], BUFFER);
  }
 
 unsignedchar md_value[EVP_MAX_MD_SIZE];
@@ -4132,10 +4130,8 @@ void Sign::SignFinal(const FunctionCallbackInfo<Value>& args){
 
 unsignedint len = args.Length();
 enum encoding encoding = BUFFER;
-if (len >= 2 && args[1]->IsString()){
- encoding = ParseEncoding(env->isolate(),
- args[1]->ToString(env->isolate()),
- BUFFER);
+if (len >= 2){
+ encoding = ParseEncoding(env->isolate(), args[1], BUFFER);
  }
 
  node::Utf8Value passphrase(env->isolate(), args[2]);
@@ -4348,9 +4344,7 @@ void Verify::VerifyFinal(const FunctionCallbackInfo<Value>& args){
 
 enum encoding encoding = UTF8;
 if (args.Length() >= 3){
- encoding = ParseEncoding(env->isolate(),
- args[2]->ToString(env->isolate()),
- UTF8);
+ encoding = ParseEncoding(env->isolate(), args[2], UTF8);
  }
 
 ssize_t hlen = StringBytes::Size(env->isolate(), args[1], encoding);

test/parallel/test-regress-GH-9819.js

@@ -0,0 +1,24 @@
+'use strict';
+constcommon=require('../common');
+constassert=require('assert');
+constexecFile=require('child_process').execFile;
+
+if(!common.hasCrypto){
+common.skip('missing crypto');
+return;
+}
+
+constsetup='const enc ={toString: () =>{throw new Error("xyz")} };';
+
+constscripts=[
+'crypto.createHash("sha256").digest(enc)',
+'crypto.createHmac("sha256", "msg").digest(enc)'
+];
+
+scripts.forEach((script)=>{
+constnode=process.execPath;
+constcode=setup+''+script;
+execFile(node,['-e',code],common.mustCall((err,stdout,stderr)=>{
+assert(stderr.includes('Error: xyz'),'digest crashes');
+}));
+});