test: fix deprecation warning in binding.cc

danbev · MylesBorins · commit 78e79c7f7d06 · 2018-08-16T01:59:14.000-04:00
Currently, the make-callback-domain-warning addon generates the following warning: ../binding.cc:22:9: warning: 'MakeCallback' is deprecated: Use MakeCallback(..., async_context) [-Wdeprecated-declarations] node::MakeCallback(isolate, recv, method, 0, nullptr); ^ ../../../../src/node.h:172:50: note: 'MakeCallback' has been explicitly marked deprecated here NODE_EXTERN v8::Local<v8::Value> MakeCallback( ^ 1 warning generated. This commit fixes this warning. PR-URL: #18877 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
diff --git a/test/addons/make-callback-recurse/binding.cc b/test/addons/make-callback-recurse/binding.cc
@@ -19,7 +19,8 @@ void MakeCallback(const FunctionCallbackInfo<Value>& args){
 Local<Object> recv = args[0].As<Object>();
 Local<Function> method = args[1].As<Function>();
 
- node::MakeCallback(isolate, recv, method, 0, nullptr);
+ node::MakeCallback(isolate, recv, method, 0, nullptr,
+ node::async_context{0, 0});
 }
 
 void Initialize(Local<Object> exports){

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,8 @@ void MakeCallback(const FunctionCallbackInfo<Value>& args){`
`19`	`19`	`Local<Object> recv = args[0].As<Object>();`
`20`	`20`	`Local<Function> method = args[1].As<Function>();`
`21`	`21`
`22`		`-node::MakeCallback(isolate, recv, method, 0, nullptr);`
	`22`	`+node::MakeCallback(isolate, recv, method, 0, nullptr,`
	`23`	`+ node::async_context{0, 0});`
`23`	`24`	`}`
`24`	`25`
`25`	`26`	`voidInitialize(Local<Object> exports){`