crypto: fix DiffieHellman argument validation

Fixes: #37808 PR-URL: #37810 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Filip Skokan <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>

Author: aduh95

lib/internal/crypto/diffiehellman.js

@@ -118,12 +118,20 @@ function DiffieHellman(sizeOrKey, keyEncoding, generator, genEncoding){
 if(typeofsizeOrKey!=='number')
 sizeOrKey=toBuf(sizeOrKey,keyEncoding);
 
-if(!generator)
+if(!generator){
 generator=DH_GENERATOR;
-elseif(typeofgenerator==='number')
+}elseif(typeofgenerator==='number'){
 validateInt32(generator,'generator');
-else
+}elseif(generator!==true){
 generator=toBuf(generator,genEncoding);
+}else{
+thrownewERR_INVALID_ARG_TYPE(
+'generator',
+['number','string','ArrayBuffer','Buffer','TypedArray','DataView'],
+generator
+);
+}
+
 
 this[kHandle]=new_DiffieHellman(sizeOrKey,generator);
 ObjectDefineProperty(this,'verifyError',{

test/parallel/test-crypto-dh.js

@@ -489,3 +489,9 @@ assert.throws(
 'crypto.getDiffieHellman(\'modp1\').setPublicKey(\'\') '+
 'failed to throw the expected error.'
 );
+assert.throws(
+()=>crypto.createDiffieHellman('',true),
+{
+code: 'ERR_INVALID_ARG_TYPE'
+}
+);