console: colorize console error and warn

prints console error in red and warn in yellow PR-URL: #51629 Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Ruy Adorno <[email protected]> Reviewed-By: James M Snell <[email protected]>

Author: MrJithil

lib/internal/console/constructor.js

@@ -8,6 +8,7 @@ const{
  ArrayIsArray,
  ArrayPrototypeForEach,
  ArrayPrototypePush,
+ ArrayPrototypeSome,
  ArrayPrototypeUnshift,
  Boolean,
  ErrorCaptureStackTrace,
@@ -67,6 +68,7 @@ const{
 CHAR_LOWERCASE_N: kTraceInstant,
 CHAR_UPPERCASE_C: kTraceCount,
 }=require('internal/constants');
+const{ styleText }=require('util');
 constkCounts=Symbol('counts');
 
 constkTraceConsoleCategory='node,node.console';
@@ -273,7 +275,7 @@ ObjectDefineProperties(Console.prototype,{
 [kWriteToConsole]: {
 __proto__: null,
  ...consolePropAttributes,
-value: function(streamSymbol,string){
+value: function(streamSymbol,string,color=''){
 constignoreErrors=this._ignoreErrors;
 constgroupIndent=this[kGroupIndent];
 
@@ -288,6 +290,11 @@ ObjectDefineProperties(Console.prototype,{
 }
 string=groupIndent+string;
 }
+
+if(color){
+string=styleText(color,string);
+}
+
 string+='\n';
 
 if(ignoreErrors===false)returnstream.write(string);
@@ -378,12 +385,15 @@ const consoleMethods ={
 log(...args){
 this[kWriteToConsole](kUseStdout,this[kFormatForStdout](args));
 },
-
-
 warn(...args){
-this[kWriteToConsole](kUseStderr,this[kFormatForStderr](args));
+constcolor=(shouldColorize(args)&&'yellow')||'';
+this[kWriteToConsole](kUseStderr,this[kFormatForStderr](args),color);
 },
 
+error(...args){
+constcolor=(shouldColorize(args)&&'red')||'';
+this[kWriteToConsole](kUseStderr,this[kFormatForStderr](args),color);
+},
 
 dir(object,options){
 this[kWriteToConsole](kUseStdout,inspect(object,{
@@ -676,6 +686,12 @@ const iterKey = '(iteration index)'
 
 constisArray=(v)=>ArrayIsArray(v)||isTypedArray(v)||isBuffer(v);
 
+// TODO: remove string type check once the styleText supports objects
+// Return true if all args are type string
+constshouldColorize=(args)=>{
+returnlazyUtilColors().hasColors&&!ArrayPrototypeSome(args,(arg)=>typeofarg!=='string');
+};
+
 functionnoop(){}
 
 for(constmethodofReflectOwnKeys(consoleMethods))
@@ -684,7 +700,6 @@ for (const method of ReflectOwnKeys(consoleMethods))
 Console.prototype.debug=Console.prototype.log;
 Console.prototype.info=Console.prototype.log;
 Console.prototype.dirxml=Console.prototype.log;
-Console.prototype.error=Console.prototype.warn;
 Console.prototype.groupCollapsed=Console.prototype.group;
 
 functioninitializeGlobalConsole(globalConsole){

test/parallel/test-repl.js

@@ -764,6 +764,7 @@ const errorTests = [
 'Object [console]{',
 ' log: [Function: log],',
 ' warn: [Function: warn],',
+' error: [Function: error],',
 ' dir: [Function: dir],',
 ' time: [Function: time],',
 ' timeEnd: [Function: timeEnd],',
@@ -779,7 +780,6 @@ const errorTests = [
 /{2}debug:\[Function:(debug|log)],/,
 /{2}info:\[Function:(info|log)],/,
 /{2}dirxml:\[Function:(dirxml|log)],/,
-/{2}error:\[Function:(error|warn)],/,
 /{2}groupCollapsed:\[Function:(groupCollapsed|group)],/,
 /{2}Console:\[Function:Console],?/,
  ...process.features.inspector ? [

test/pseudo-tty/test-tty-color-support-warning-2.out

@@ -1,3 +1,3 @@
 
-(node:*) Warning: The 'NODE_DISABLE_COLORS' env is ignored due to the 'FORCE_COLOR' env being set.
-(Use `* --trace-warnings ...` to show where the warning was created)
+*(node:*) Warning: The 'NODE_DISABLE_COLORS' env is ignored due to the 'FORCE_COLOR' env being set.
+(Use `* --trace-warnings ...` to show where the warning was created)*

test/pseudo-tty/test-tty-color-support-warning.out

@@ -1,3 +1,3 @@
 
-(node:*) Warning: The 'NODE_DISABLE_COLORS' and 'NO_COLOR' env is ignored due to the 'FORCE_COLOR' env being set.
-(Use `* --trace-warnings ...` to show where the warning was created)
+*(node:*) Warning: The 'NODE_DISABLE_COLORS' and 'NO_COLOR' env is ignored due to the 'FORCE_COLOR' env being set.
+(Use `* --trace-warnings ...` to show where the warning was created)*

test/pseudo-tty/test-tty-color-support.out

@@ -1,2 +1,2 @@
-(node:*) Warning: The 'NO_COLOR' env is ignored due to the 'FORCE_COLOR' env being set.
-(Use `* --trace-warnings ...` to show where the warning was created)
+*(node:*) Warning: The 'NO_COLOR' env is ignored due to the 'FORCE_COLOR' env being set.
+(Use `* --trace-warnings ...` to show where the warning was created)*