lib: replace var with let

Dennis Saenger · addaleax · commit 797b938c49e8 · 2019-11-30T03:56:08.000+01:00
PR-URL: #30396 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
diff --git a/lib/internal/v8_prof_polyfill.js b/lib/internal/v8_prof_polyfill.js
@@ -77,7 +77,7 @@ try{
 const fd = fs.openSync(logFile, 'r');
 const buf = Buffer.allocUnsafe(4096);
 const dec = new (require('string_decoder').StringDecoder)('utf-8');
-var line = '';
+let line = '';
 
{
 const message = versionCheck(peekline(), process.versions.v8);
@@ -125,7 +125,7 @@ function versionCheck(firstLine, expected){
 return 'Unable to read v8-version from log file.';
 }
 // Compare major, minor and build; ignore the patch and candidate fields.
- for (var i = 0; i < 3; i++)
+ for (let i = 0; i < 3; i++)
 if (curVer[i] !== firstLine[i + 1])
 return 'Testing v8 version different from logging version';
 }

Original file line number	Diff line number	Diff line change
`@@ -77,7 +77,7 @@ try{`
`77`	`77`	`constfd=fs.openSync(logFile,'r');`
`78`	`78`	`constbuf=Buffer.allocUnsafe(4096);`
`79`	`79`	`constdec=new(require('string_decoder').StringDecoder)('utf-8');`
`80`		`-varline='';`
	`80`	`+letline='';`
`81`	`81`
`82`	`82`	`{`
`83`	`83`	`constmessage=versionCheck(peekline(),process.versions.v8);`
`@@ -125,7 +125,7 @@ function versionCheck(firstLine, expected){`
`125`	`125`	`return'Unable to read v8-version from log file.';`
`126`	`126`	`}`
`127`	`127`	`// Compare major, minor and build; ignore the patch and candidate fields.`
`128`		`-for(vari=0;i<3;i++)`
	`128`	`+for(leti=0;i<3;i++)`
`129`	`129`	`if(curVer[i]!==firstLine[i+1])`
`130`	`130`	`return'Testing v8 version different from logging version';`
`131`	`131`	`}`