process: fix symbol key and mark experimental new node:process methods

PR-URL: #56517 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]>

Author: aduh95

doc/api/process.md

@@ -3234,11 +3234,13 @@ console.log(`The parent process is pid ${ppid}`);
 added: v23.6.0
 -->
 
+> Stability: 1 - Experimental
+
 * `maybeRefable`{any} An object that may be "refable".
 
 An object is "refable" if it implements the Node.js "Refable protocol".
-Specifically, this means that the object implements the `Symbol.for('node:ref')`
-and `Symbol.for('node:unref')` methods. "Ref'd" objects will keep the Node.js
+Specifically, this means that the object implements the `Symbol.for('nodejs.ref')`
+and `Symbol.for('nodejs.unref')` methods. "Ref'd" objects will keep the Node.js
 event loop alive, while "unref'd" objects will not. Historically, this was
 implemented by using `ref()` and `unref()` methods directly on the objects.
 This pattern, however, is being deprecated in favor of the "Refable protocol"
@@ -4291,11 +4293,13 @@ In [`Worker`][] threads, `process.umask(mask)` will throw an exception.
 added: v23.6.0
 -->
 
+> Stability: 1 - Experimental
+
 * `maybeUnfefable`{any} An object that may be "unref'd".
 
 An object is "unrefable" if it implements the Node.js "Refable protocol".
-Specifically, this means that the object implements the `Symbol.for('node:ref')`
-and `Symbol.for('node:unref')` methods. "Ref'd" objects will keep the Node.js
+Specifically, this means that the object implements the `Symbol.for('nodejs.ref')`
+and `Symbol.for('nodejs.unref')` methods. "Ref'd" objects will keep the Node.js
 event loop alive, while "unref'd" objects will not. Historically, this was
 implemented by using `ref()` and `unref()` methods directly on the objects.
 This pattern, however, is being deprecated in favor of the "Refable protocol"

lib/internal/process/per_thread.js

@@ -421,12 +421,14 @@ function toggleTraceCategoryState(asyncHooksEnabled){
 const{ arch, platform, version }=process;
 
 functionref(maybeRefable){
-constfn=maybeRefable?.[SymbolFor('node:ref')]||maybeRefable?.ref;
+constfn=maybeRefable?.[SymbolFor('nodejs.ref')]||maybeRefable?.[SymbolFor('node:ref')]||maybeRefable?.ref;
 if(typeoffn==='function')FunctionPrototypeCall(fn,maybeRefable);
 }
 
 functionunref(maybeRefable){
-constfn=maybeRefable?.[SymbolFor('node:unref')]||maybeRefable?.unref;
+constfn=maybeRefable?.[SymbolFor('nodejs.unref')]||
+maybeRefable?.[SymbolFor('node:unref')]||
+maybeRefable?.unref;
 if(typeoffn==='function')FunctionPrototypeCall(fn,maybeRefable);
 }
 

test/parallel/test-process-ref-unref.js

@@ -23,6 +23,18 @@ class Foo{
 }
 
 classFoo2{
+refCalled=0;
+unrefCalled=0;
+[Symbol.for('nodejs.ref')](){
+this.refCalled++;
+}
+[Symbol.for('nodejs.unref')](){
+this.unrefCalled++;
+}
+}
+
+// TODO(aduh95): remove support for undocumented symbol
+classFoo3{
 refCalled=0;
 unrefCalled=0;
 [Symbol.for('node:ref')](){
@@ -39,14 +51,19 @@ describe('process.ref/unref work as expected', () =>{
 // just work.
 constfoo1=newFoo();
 constfoo2=newFoo2();
+constfoo3=newFoo3();
 process.ref(foo1);
 process.unref(foo1);
 process.ref(foo2);
 process.unref(foo2);
+process.ref(foo3);
+process.unref(foo3);
 strictEqual(foo1.refCalled,1);
 strictEqual(foo1.unrefCalled,1);
 strictEqual(foo2.refCalled,1);
 strictEqual(foo2.unrefCalled,1);
+strictEqual(foo3.refCalled,1);
+strictEqual(foo3.unrefCalled,1);
 
 // Objects that implement the legacy API also just work.
 consti=setInterval(()=>{},1000);