lib: define FormData and fetch etc. in the built-in snapshot

Now that --experimental-fetch is true by default, define the dependent interfaces in the built-in snapshot and only delete them at run time when --no-experimental-fetch is set. PR-URL: #51598 Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Matthew Aitken <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>

Author: joyeecheung

lib/internal/bootstrap/web/exposed-window-or-worker.js

@@ -10,6 +10,7 @@
 
 const{
  globalThis,
+ ObjectDefineProperty,
 }=primordials;
 
 const{
@@ -55,3 +56,44 @@ defineReplaceableLazyAttribute(globalThis, 'perf_hooks', ['performance']);
 // https://w3c.github.io/FileAPI/#creating-revoking
 const{ installObjectURLMethods }=require('internal/url');
 installObjectURLMethods();
+
+{
+// https://fetch.spec.whatwg.org/#fetch-method
+functionset(value){
+ObjectDefineProperty(globalThis,'fetch',{
+__proto__: null,
+writable: true,
+ value,
+});
+}
+ObjectDefineProperty(globalThis,'fetch',{
+__proto__: null,
+configurable: true,
+enumerable: true,
+ set,
+get(){
+functionfetch(input,init=undefined){
+// Loading undici alone lead to promises which breaks lots of tests so we
+// have to load it really lazily for now.
+const{fetch: impl}=require('internal/deps/undici/undici');
+returnimpl(input,init);
+}
+set(fetch);
+returnfetch;
+},
+});
+}
+
+// https://xhr.spec.whatwg.org/#interface-formdata
+// https://fetch.spec.whatwg.org/#headers-class
+// https://fetch.spec.whatwg.org/#request-class
+// https://fetch.spec.whatwg.org/#response-class
+exposeLazyInterfaces(globalThis,'internal/deps/undici/undici',[
+'FormData','Headers','Request','Response',
+]);
+
+// The WebAssembly Web API which relies on Response.
+// https:// webassembly.github.io/spec/web-api/#streaming-modules
+internalBinding('wasm_web_api').setImplementation((streamState,source)=>{
+require('internal/wasm_web_api').wasmStreamingCallback(streamState,source);
+});

lib/internal/process/pre_execution.js

@@ -10,7 +10,6 @@ const{
  DatePrototypeGetMonth,
  DatePrototypeGetSeconds,
  NumberParseInt,
- ObjectDefineProperties,
  ObjectDefineProperty,
  ObjectFreeze,
  ObjectGetOwnPropertyDescriptor,
@@ -30,7 +29,6 @@ const{
 }=require('internal/options');
 const{ reconnectZeroFillToggle }=require('internal/buffer');
 const{
- defineOperation,
  exposeInterface,
  exposeLazyInterfaces,
  defineReplaceableLazyAttribute,
@@ -302,58 +300,16 @@ function setupWarningHandler(){
 // https://fetch.spec.whatwg.org/
 // https://websockets.spec.whatwg.org/
 functionsetupUndici(){
-if(getEmbedderOptions().noBrowserGlobals){
-return;
-}
-
-letundici;
-functionlazyUndici(){
-if(undici){
-returnundici;
-}
-
-undici=require('internal/deps/undici/undici');
-returnundici;
-}
-
-functionlazyInterface(name){
-return{
-configurable: true,
-enumerable: false,
-get(){
-returnlazyUndici()[name];
-},
-set(value){
-exposeInterface(globalThis,name,value);
-},
-};
+if(getOptionValue('--no-experimental-fetch')){
+deleteglobalThis.fetch;
+deleteglobalThis.FormData;
+deleteglobalThis.Headers;
+deleteglobalThis.Request;
+deleteglobalThis.Response;
 }
 
-if(!getOptionValue('--no-experimental-fetch')){
-// Fetch is meant to return a Promise, but not be async.
-functionfetch(input,init=undefined){
-returnlazyUndici().fetch(input,init);
-}
-
-defineOperation(globalThis,'fetch',fetch);
-
-ObjectDefineProperties(globalThis,{
-FormData: lazyInterface('FormData'),
-Headers: lazyInterface('Headers'),
-Request: lazyInterface('Request'),
-Response: lazyInterface('Response'),
-});
-
-// The WebAssembly Web API: https://webassembly.github.io/spec/web-api
-internalBinding('wasm_web_api').setImplementation((streamState,source)=>{
-require('internal/wasm_web_api').wasmStreamingCallback(streamState,source);
-});
-}
-
-if(getOptionValue('--experimental-websocket')){
-ObjectDefineProperties(globalThis,{
-WebSocket: lazyInterface('WebSocket'),
-});
+if(!getEmbedderOptions().noBrowserGlobals&&getOptionValue('--experimental-websocket')){
+exposeLazyInterfaces(globalThis,'internal/deps/undici/undici',['WebSocket']);
 }
 }
 

test/parallel/test-bootstrap-modules.js

@@ -98,10 +98,10 @@ expected.beforePreExec = new Set([
 'NativeModule internal/modules/package_json_reader',
 'Internal Binding module_wrap',
 'NativeModule internal/modules/cjs/loader',
+'Internal Binding wasm_web_api',
 ]);
 
 expected.atRunTime=newSet([
-'Internal Binding wasm_web_api',
 'Internal Binding worker',
 'NativeModule internal/modules/run_main',
 'NativeModule internal/net',