fs: remove unnecessary option argument validation

JonasBa · targos · commit 8086337ea9e8 · 2024-07-28T08:53:28.000+02:00
PR-URL: #53861 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
diff --git a/lib/fs.js b/lib/fs.js
@@ -1349,19 +1349,20 @@ function mkdirSync(path, options){
 let mode = 0o777;
 let recursive = false;
 if (typeof options === 'number' || typeof options === 'string'){
- mode = options;
+ mode = parseFileMode(options, 'mode');
 } else if (options){
- if (options.recursive !== undefined)
+ if (options.recursive !== undefined){
 recursive = options.recursive;
- if (options.mode !== undefined)
- mode = options.mode;
+ validateBoolean(recursive, 'options.recursive');
+ }
+ if (options.mode !== undefined){
+ mode = parseFileMode(options.mode, 'options.mode');
+ }
 }
- path = getValidatedPath(path);
- validateBoolean(recursive, 'options.recursive');
 
 const result = binding.mkdir(
- path,
- parseFileMode(mode, 'mode'),
+ getValidatedPath(path),
+ mode,
 recursive,
 );
 

-Original file line number
+Diff line change
 letmode=0o777;
 letrecursive=false;
 if(typeofoptions==='number'||typeofoptions==='string'){
 -mode=options;
 +mode=parseFileMode(options,'mode');
 }elseif(options){
 -if(options.recursive!==undefined)
 +if(options.recursive!==undefined){
 recursive=options.recursive;
 -if(options.mode!==undefined)
 -mode=options.mode;
 +validateBoolean(recursive,'options.recursive');
 +}
 +if(options.mode!==undefined){
 +mode=parseFileMode(options.mode,'options.mode');
 +}
+}
 -path=getValidatedPath(path);
 -validateBoolean(recursive,'options.recursive');
 constresult=binding.mkdir(
 -path,
 -parseFileMode(mode,'mode'),
 +getValidatedPath(path),
 +mode,
 recursive,
 );