tools: fix custom eslint rule errors

This fixes a few rules by making sure the input is actually ready to be checked. Otherwise those can throw TypeErrors or result in faulty error messages. PR-URL: #18853 Reviewed-By: Luigi Pinca <[email protected]>

Author: BridgeAR

tools/eslint-rules/alphabetize-errors.js

@@ -1,19 +1,14 @@
 'use strict';
 
+const{ isDefiningError }=require('./rules-utils.js');
+
 constprefix='Out of ASCIIbetical order - ';
 constopStr=' >= ';
 
 functionerrorForNode(node){
 returnnode.expression.arguments[0].value;
 }
 
-functionisDefiningError(node){
-returnnode.expression&&
-node.expression.type==='CallExpression'&&
-node.expression.callee&&
-node.expression.callee.name==='E';
-}
-
 module.exports={
 create: function(context){
 letpreviousNode;

tools/eslint-rules/rules-utils.js

@@ -3,6 +3,14 @@
  */
 'use strict';
 
+module.exports.isDefiningError=function(node){
+returnnode.expression&&
+node.expression.type==='CallExpression'&&
+node.expression.callee&&
+node.expression.callee.name==='E'&&
+node.expression.arguments.length!==0;
+};
+
 /**
  * Returns true if any of the passed in modules are used in
  * require calls.